Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing a user who is a project owner should raise a warning / error #498

Open
mboudet opened this issue Aug 27, 2024 · 2 comments · May be fixed by #566
Open

Removing a user who is a project owner should raise a warning / error #498

mboudet opened this issue Aug 27, 2024 · 2 comments · May be fixed by #566

Comments

@mboudet
Copy link
Member

mboudet commented Aug 27, 2024

No description provided.

@rsiminel
Copy link
Contributor

rsiminel commented Sep 5, 2024

You mean kind of like this one ?
image

That error message is coded in user.service.js.

@mboudet
Copy link
Member Author

mboudet commented Sep 5, 2024

Yes, something like this also in the delete route:

https://github.com/genouest/genouestaccountmanager/blob/master/routes/users.js#L52
(Actually, we also need to check if the deletion workflow properly works with projects, ie the user should be removed from existing projets.

IIRC, projet membership is stored on the user, and not on the project, so we probably don't need to do anything aside from checking if the user is owner or the last member of a projet

@rsiminel rsiminel linked a pull request Dec 9, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants