Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workflow for building and publishing images #4

Open
2 tasks done
schneiderfelipe opened this issue Nov 18, 2021 · 2 comments
Open
2 tasks done

Workflow for building and publishing images #4

schneiderfelipe opened this issue Nov 18, 2021 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@schneiderfelipe
Copy link
Member

schneiderfelipe commented Nov 18, 2021

I propose:

  • Image builds on PRs and on pushes/merges to master
  • Publishing on pushes/merges to master

This ensures we don't publish problematic images and the master branch is always up-to-date and passing builds.

This will require two GH actions.

@Leticia-maria
Copy link
Member

Leticia-maria commented Nov 19, 2021

Okay @schneiderfelipe, thank you for opening the discussion as an issue. I'll check this out and solve it. I also suggest correcting the build sequence. I mean, only build the updates, not all the images every time we change something. This takes a lot of running time, as you can see in the GH actions logfile.

  • Build only when Dockerfiles are updated
  • Not build all the images to verify a PR

@Leticia-maria Leticia-maria self-assigned this Nov 19, 2021
@Leticia-maria
Copy link
Member

  • Create a separate workflow to build a PR

@Leticia-maria Leticia-maria added the enhancement New feature or request label Nov 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants