New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issues highlighted by admin/cli/check_database_schema.php #66

Open

abias opened this issue Jul 23, 2021 · 0 comments

abias commented Jul 23, 2021

Every now and then, we are running the admin/cli/check_database_schema.php script in our Moodle installation.

This time, this issue was highlighted:

-------------------------------------------------------------------------------
qtype_ordering_options
 * column 'showgrading' has default '1', expected '0' (I)
-------------------------------------------------------------------------------

Upon investigation, I saw that there is a discrepancy between https://github.com/gbateson/moodle-qtype_ordering/blob/master/db/install.xml#L12 and https://github.com/gbateson/moodle-qtype_ordering/blob/master/db/upgrade.php#L225. The first defines a default of 0, the second (which became effective in our Moodle instance as we are using this plugin for a long time now) defines a default of 1.

May I ask you to add another step to db/upgrade.php which fixes the default for upgraded installations?

Thanks in advance,
Alex

The text was updated successfully, but these errors were encountered:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment