Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CLI Build Pipeline #23

Closed
5 of 7 tasks
In-Ko opened this issue Feb 1, 2021 · 5 comments
Closed
5 of 7 tasks

Update CLI Build Pipeline #23

In-Ko opened this issue Feb 1, 2021 · 5 comments
Assignees
Labels
component/landscaper-ext effort/2d Effort for issue is around 2 days kind/task General task
Milestone

Comments

@In-Ko
Copy link
Collaborator

In-Ko commented Feb 1, 2021

Description
In order to ensure best possible quality for the landscaper cli, we have to update the pipeline in such a way that it runs the CLI Test Suite, and only creates a new Release of the CLI if all Tests run through completely.
If a test fails, the pipeline must report the failing test (as usual, see Potter pipelines ...) in a human readable protocol, so that it is easy to identify the problem.

Done Criteria

  • All Features implemented
  • Code has been reviewed by other team members
  • Unit Tests created for new code
  • Integration Test Suite updated (if applicable)
  • Internal technical Documentation updated
  • Enduser Documentation updated (if applicable)
  • Successful demonstration in Review
@In-Ko In-Ko added kind/task General task size/s Size of pull request is small (see gardener-robot robot/bots/size.py) component/landscaper-ext labels Feb 1, 2021
@guewa guewa self-assigned this Feb 1, 2021
@guewa
Copy link
Collaborator

guewa commented Feb 12, 2021

@In-Ko
Copy link
Collaborator Author

In-Ko commented Feb 15, 2021

Status after Sprint 1b:

  • Integration Test Suite integrated in build pipeline

Leftovers:

  • Integration Test Suite should run every 2 hrs for Dev
  • Integration Test Suite should run "on pull-request".
    • This needs to be thought through, as tests must not compete with each other if they run in parallel.
  • Pipeline has to perform a make generate command to update the documentation of the CLI.
    • This could be done with our pre-commit hook, which could run the make generate

@In-Ko In-Ko added this to the 2021-Q1 milestone Feb 15, 2021
@guewa
Copy link
Collaborator

guewa commented Feb 18, 2021

@guewa
Copy link
Collaborator

guewa commented Feb 23, 2021

Integration Tests now suppresses parallel execution and have their own clusters:

  • 2h cron job: int-test-cron
  • Pull Request: int-test-pr
  • Release: int-test
    This ensures that the needed installation/deinstallation of the landscaper doesn't mess with each other

@In-Ko
Copy link
Collaborator Author

In-Ko commented Mar 1, 2021

This is done for now.

@In-Ko In-Ko closed this as completed Mar 1, 2021
@gardener-robot gardener-robot added effort/2d Effort for issue is around 2 days and removed size/s Size of pull request is small (see gardener-robot robot/bots/size.py) labels Mar 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/landscaper-ext effort/2d Effort for issue is around 2 days kind/task General task
Projects
None yet
Development

No branches or pull requests

3 participants