Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt gammapyXray to gammapy 1.3 #2

Open
lheckmann opened this issue Nov 27, 2024 · 0 comments
Open

Adapt gammapyXray to gammapy 1.3 #2

lheckmann opened this issue Nov 27, 2024 · 0 comments

Comments

@lheckmann
Copy link
Collaborator

When running the example_nb.ipynb in gammapy-ogip-spectra, I needed to adapt two small things in gammapyXray to be compatible with gammapy version 1.3:

  1. in models.py:
    L32ff:
            parameter = Parameter(
                name=par.name, value=par.val, frozen=par.frozen, is_norm=is_norm
            )

is_norm has to be removed since it has been remove from Parameter()

  1. in ogip_spectrum_dataset.py
    L118ff:
    In the definition of npred_signal, all model_name occurrences should be updated to model_names to match the current format in SpectrumDatasetOnOff.npred_signal() in gammapy 1.3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant