Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some OGIP files for SED / LC estimation tests (joint-crab OGIP outdated) #34

Open
cosimoNigro opened this issue Dec 17, 2022 · 0 comments

Comments

@cosimoNigro
Copy link
Contributor

cosimoNigro commented Dec 17, 2022

I wanted to make a quick snippet to share with the devs to illustrate a possible problem I found with LC estimation.

I realised that the only OGIP files that we have here are those in the joint-crab/spectra subdirectory.
These work fine for spectra estimation, but don't work with the LightCurveEstimator as they don't have a GTI HDU, as other OGIP files produced with more recent versions of Gammapy.

Should we add newer versions of OGIP files for these types of tests?

@cosimoNigro cosimoNigro changed the title Add some OGIP files for spectra estimation tests (joint-crab OGIP outdated) Add some OGIP files for SED / LC estimation tests (joint-crab OGIP outdated) Dec 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant