Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Displaying frame comments in workflow rendering #5591

Open
hexylena opened this issue Dec 3, 2024 · 2 comments
Open

Displaying frame comments in workflow rendering #5591

hexylena opened this issue Dec 3, 2024 · 2 comments

Comments

@hexylena
Copy link
Member

hexylena commented Dec 3, 2024

This one has frame comments, could this be integrated?
image

Originally posted by @lldelisle in #5543 (comment)

@hexylena
Copy link
Member Author

hexylena commented Dec 3, 2024

@lldelisle There is no plan now to do that given the following situation:

  • in order to render frame comments we need to semi-accurately render the rest of the workflow (including layout/placement)
  • currently this is only available within galaxy, not as some reusable external component

so in order to render that we'd have to

  • upload every workflow to at least one galaxy server
  • generate the iframes pointing to that

we've considered that in the past, maybe also to give users an easier "click to run" experience because the workflows would be automatically across e.g. the usegalaxy.* servers, but, I guess it is a question of return on investment. It would be nice, and the galaxy rendering will always be better, but, then we also need to worry about which server has all of the relevant tools so the workflow will render properly. Unfortunately usegalaxy.* haven't managed to unify tools, nor to ensure 100% GTN tutorial support, so, I don't feel as confident in that approach for now, but maybe that'll change significantly in the future.

We'd still need to see if we want to have a GTN account everywhere that's responsible for maintaining up-to-date copies of the workflows on each server, and if that is in fact, useful.

@hexylena
Copy link
Member Author

hexylena commented Dec 3, 2024

What we could consider doing is trying to figure out which tools are in those boxes, and providing that information to Mermaid, but, I'm not sure how difficult that would be. It would not look like the original, and we wouldn't be copying over any markdown content, but, maybe it would be sufficiently interesting for this use case.

@lldelisle do you have a link to that workflow that I could look at in more detail?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant