Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

volcanoplot bump #6622

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

bgruening
Copy link
Member

@bgruening bgruening commented Dec 11, 2024

FOR CONTRIBUTOR:

  • I have read the CONTRIBUTING.md document and this tool is appropriate for the tools-iuc repo.
  • License permits unrestricted use (educational + commercial)
  • This PR adds a new tool or tool collection
  • This PR updates an existing tool or tool collection
  • This PR does something else (explain below)

fixes #6620

@pcm32
Copy link
Member

pcm32 commented Dec 11, 2024

Maybe on this one you want to link the use of the macros? or this tool is not using them? Also, I presume that there might be some default or something missing on the Display categories by: variable which made the workflow invocations fail? So that people can use this in workflows later.

@pcm32
Copy link
Member

pcm32 commented Dec 11, 2024

This was the hidden error that this tool was generating (there is actually more than one variable):

bioblend.ConnectionError: Unexpected HTTP status code: 400: {"err_msg": {"shape_col": "No value found for 'Categories that can be used to plot different shapes or facet (useful if multivariable associations are investigated)'.", "shape_or_facet"
: "No value found for 'Display categories by:'."}, "err_code": 0, "err_data": {"39": {"shape_col": "No value found for 'Categories that can be used to plot different shapes or facet (useful if multivariable associations are investigated)'.", "sh
ape_or_facet": "No value found for 'Display categories by:'."}}}

@bgruening
Copy link
Member Author

This tool does not have a macro: https://github.com/bgruening/tools-iuc/tree/volcanoplot_bump/tools/volcanoplot

Or are you saying you want to have something in a macro?

@pcm32
Copy link
Member

pcm32 commented Dec 11, 2024

If it doesn't don't worry, I thought it had one.

@pcm32
Copy link
Member

pcm32 commented Dec 13, 2024

I think that for some reason these two fields generate some effect on the workflow editor:

<param name="shape_col" type="data_column" data_ref="input" label="Categories that can be used to plot different shapes or facet (useful if multivariable associations are investigated)" optional="true" />
<param name="shape_or_facet" type="select" label="Display categories by:" help="Choose whether to display categories by faceting the plot or using shape." optional="true">
<option value="facet">Facet</option>
<option value="shape">Shape</option>
</param>

or could it be that because the version jumped and the tool was not added manually some values don't initialise correctly? I could never fix it in the workflow editor. Maybe the select needs a default?

Copy link
Contributor

@bernt-matthias bernt-matthias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's go ahead. If you like use the opportunity and bump the profile version.

@bernt-matthias
Copy link
Contributor

This was the hidden error that this tool was generating (there is actually more than one variable):

bioblend.ConnectionError: Unexpected HTTP status code: 400: {"err_msg": {"shape_col": "No value found for 'Categories that can be used to plot different shapes or facet (useful if multivariable associations are investigated)'.", "shape_or_facet"
: "No value found for 'Display categories by:'."}, "err_code": 0, "err_data": {"39": {"shape_col": "No value found for 'Categories that can be used to plot different shapes or facet (useful if multivariable associations are investigated)'.", "sh
ape_or_facet": "No value found for 'Display categories by:'."}}}

Would be interesting what the input dataset is, seems that the data_column parameter can not determine columns.

@bernt-matthias
Copy link
Contributor

Maybe the select needs a default?

Non optional selects automatically have a default: the first option.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants