Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update proteinortho=6.3.4 #6611

Merged
merged 3 commits into from
Dec 13, 2024
Merged

update proteinortho=6.3.4 #6611

merged 3 commits into from
Dec 13, 2024

Conversation

pmjklemm
Copy link
Contributor

@pmjklemm pmjklemm commented Dec 5, 2024

FOR CONTRIBUTOR:

  • I have read the CONTRIBUTING.md document and this tool is appropriate for the tools-iuc repo.
  • License permits unrestricted use (educational + commercial)
  • This PR adds a new tool or tool collection
  • This PR updates an existing tool or tool collection
  • This PR does something else (explain below)

@bernt-matthias
Copy link
Contributor

Thanks for keeping this up to date. I guess there is a problem to resolve the environment. Can the other requirements of the too be updated as well? Alternatively, would it be possible to include all requirements in the bioconda recipe?

@pmjklemm
Copy link
Contributor Author

@bernt-matthias, thanks for the tip, I was reading the error logs but did not find the cause of the failing CI.
I will update the requirements.
For the bioconda recipe: I wanted to keep the bioconda as minimal as possible (so only diamond is included there) but include them here in the galaxy package

@bernt-matthias
Copy link
Contributor

The problem might be our container building / mamba .. I think this will be solved today.

Thanks for updating the requirements.

The idea to keep the bioconda recipe minimal sounds perfectly reasonable to me.

@pmjklemm pmjklemm changed the title update proteinortho=6.3.3 update proteinortho=6.3.4 Dec 13, 2024
@pmjklemm
Copy link
Contributor Author

pmjklemm commented Dec 13, 2024

Thank you, seems to be working now 👍
Updates from last commit:

  • updated to 6.3.4 (fixed a bug with mmseqs)
  • added mmseqs as a algorithm to use here
  • fixed one test that should use blat but tested blast
  • improved help text

@bgruening bgruening merged commit e151cf9 into galaxyproject:main Dec 13, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants