-
Notifications
You must be signed in to change notification settings - Fork 443
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hicexplorer 3.7.6 #6595
Hicexplorer 3.7.6 #6595
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @joachimwolff nice to see you here again.
I hope bumping the samtools requirement will fix the error.
@@ -0,0 +1,225 @@ | |||
<tool id="hicexplorer_hicbuildmatrixmicroc" name="@BINARY@" version="@TOOL_VERSION@+galaxy@VERSION_SUFFIX@"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<tool id="hicexplorer_hicbuildmatrixmicroc" name="@BINARY@" version="@TOOL_VERSION@+galaxy@VERSION_SUFFIX@"> | |
<tool id="hicexplorer_hicbuildmatrixmicroc" name="@BINARY@" version="@TOOL_VERSION@+galaxy@VERSION_SUFFIX@" profile="23.0"> |
Can you please add this to all tools please?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was already there for the most tools via macros.xml. Added it where it was missing.
<import>macros.xml</import> | ||
</macros> | ||
<expand macro="requirements"> | ||
<requirement type="package" version="1.19">samtools</requirement> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<requirement type="package" version="1.19">samtools</requirement> | |
<requirement type="package" version="1.21">samtools</requirement> |
I don't know why it fails here, on the local machine of mine everything is passing. Is there a way to get the tool_test_output.html? I searched in the logs for a hint what is wrong, but don't see something obvious. |
You will find the html on this site https://github.com/galaxyproject/tools-iuc/actions/runs/12134110993?pr=6595 Unfortunately, HiCE is not providing any useful error message as it seems. Can it be that it uses too much memory? |
Is it possible to increase the memory? |
In GitHub Actions, I don't think so. But it should have 16GB? How much do you need? |
16 GB is way more than it should need, this is the usual toy data we use since at least 2016. The data was not changed, only the organisation of HiCExplorer in the background and the micro-C part drops a few parameters in comparison to hicBuildMatrix. This should all run through as always. |
Maybe you understand the error better than me. Memory was just an assumption. I will also clone it and run it locally later this day. |
Using --biocontainers leads to a fail of all tools on my local machine, but only if a subset is run. A run of all leads not to a crash, but at some point it simply hangs and does not continue to test. Unclear to me what is happening here. |
I got it locally with biocontainers running, and the hicBuildMatrix / hicBuildMatrixMicroC test cases were failing. The only difference I saw between the passing tools and the hicBuildMatrix / hicBuildMatrixMicroC was the additional requirement to samtools. After removal, the tests are passing. Given that HiCExplorer installs via conda dependency resolving a samtools version, I am not sure why we need to declare this dependency explicit in the wrapper. Samtools was not listed in the first versions of the hicBuildMatrix wrapper, only since HiCExplorer version 1.5, with a commit in December 2016: deeptools/HiCExplorer@d3b1279 |
Nice find! Thanks a lot! |
Attention: deployment failure! https://github.com/galaxyproject/tools-iuc/actions/runs/12184251422 |
1 similar comment
Attention: deployment failure! https://github.com/galaxyproject/tools-iuc/actions/runs/12184251422 |
Did I forget to add the new tool hicBuildMatrixMicroC anywhere for the suite hicexplorer? |
I did it manually, we have the problem that those tools are under |
FOR CONTRIBUTOR:
Update of HiCExplorer, new tool to build micro-C matrices.