Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new hierachical clustering tool based on scipy #6214

Merged
merged 9 commits into from
Aug 8, 2024

Conversation

wm75
Copy link
Contributor

@wm75 wm75 commented Aug 7, 2024

A tool like this was requested by @dbrites

FOR CONTRIBUTOR:

  • I have read the CONTRIBUTING.md document and this tool is appropriate for the tools-iuc repo.
  • License permits unrestricted use (educational + commercial)
  • This PR adds a new tool or tool collection
  • This PR updates an existing tool or tool collection
  • This PR does something else (explain below)

@wm75
Copy link
Contributor Author

wm75 commented Aug 7, 2024

One thing this version does not support atm is multiple heights or n_clusters values, which, on the command line would result in multi-column tabular output with the cluster assignments for all different settings.
Let me know if that seems of interest.

@wm75
Copy link
Contributor Author

wm75 commented Aug 8, 2024

We should maybe have column names for the cluster assignment output. Let me add this still before merging.

@@ -0,0 +1,6 @@
sample cluster_id_h18.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is this here h18.0 a float and below an integer? Is anything wired going on?
Any both files are identical besides the header...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

h18.0 is the height at which the tree got cut in order to produce the cluster IDs below, and height can be a float.
The results are otherwise identical because I chose --height and -n so that both tests give the same result. So before I added now the column names only a single test file was needed.

@bgruening bgruening merged commit a34052b into galaxyproject:main Aug 8, 2024
11 checks passed
nilchia pushed a commit to pavanvidem/tools-iuc that referenced this pull request Aug 24, 2024
* Add new hierachical clustering tool

* Describe input format in tool help

* Add .shed.yml

* Add edam information

* Fix flake8 issues

* Add note about test data origin

* Try to fix tests

* Update tools/clustering_from_distmat/.shed.yml

* Write column names to cluster assignment output

---------

Co-authored-by: Björn Grüning <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants