Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add flexynesis #6193

Closed
wants to merge 30 commits into from
Closed

add flexynesis #6193

wants to merge 30 commits into from

Conversation

nilchia
Copy link
Contributor

@nilchia nilchia commented Jul 29, 2024

FOR CONTRIBUTOR:

  • I have read the CONTRIBUTING.md document and this tool is appropriate for the tools-iuc repo.
  • License permits unrestricted use (educational + commercial)
  • This PR adds a new tool or tool collection
  • This PR updates an existing tool or tool collection
  • This PR does something else (explain below)

This PR adds flexynesis to Galaxy

@nilchia
Copy link
Contributor Author

nilchia commented Aug 6, 2024

The problem is that the data_types argument should be the name of the omics file (E.g. gex here).
but when the value is set to "gex" it thinks that it is a file and not a text. So it gives: --data_types {'src': 'hda', 'id': '55d23f6c34fa3eae'} for example.

@nilchia
Copy link
Contributor Author

nilchia commented Aug 6, 2024

I added another omics file and that problem is solved.

@nilchia
Copy link
Contributor Author

nilchia commented Aug 7, 2024

why does it use diff for "job.feature_importance" element?
I did not set compare="diff"

@bgruening
Copy link
Member

You specified file so you want to compare the file with something ... and the default comparison method is diff. Remove the file.

@nilchia
Copy link
Contributor Author

nilchia commented Aug 7, 2024

Thanks @bgruening !

@nilchia nilchia marked this pull request as ready for review August 7, 2024 08:45
tools/flexynesis/flexynesis.xml Outdated Show resolved Hide resolved
tools/flexynesis/macros.xml Outdated Show resolved Hide resolved
tools/flexynesis/macros.xml Outdated Show resolved Hide resolved
tools/flexynesis/macros.xml Outdated Show resolved Hide resolved
<valid initial="string.printable"></valid>
</sanitizer>
</param>
<param argument="--output_layers" type="text" label="Output layers" help="Which data types to use as output/decoded layers, comma-separated if multiple.">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume its quite hard for a user to know what this input here is. Any idea?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The --input_layers and --output_layers should be set to one or more modalities (set in --data_types)
Maybe a better help?
I'll try

Copy link
Contributor Author

@nilchia nilchia Aug 7, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it better now?

tools/flexynesis/macros.xml Outdated Show resolved Hide resolved
tools/flexynesis/flexynesis.xml Outdated Show resolved Hide resolved
tools/flexynesis/flexynesis.xml Outdated Show resolved Hide resolved
nilchia and others added 2 commits August 7, 2024 11:31
@nilchia nilchia closed this Aug 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants