-
Notifications
You must be signed in to change notification settings - Fork 441
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add metawrap (from tools-au) #5936
Conversation
This reverts commit 3b2eef3f3931ca29657b121cfc24f43e70b06f2d.
This reverts commit 68242df48e1983166ba3594e0f6ab701c6cc6aca.
This is running out of RAM
|
Co-authored-by: Björn Grüning <[email protected]>
Thanks @bgruening |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this tool
I have one question.
Would it be not better to have the folder as metawrap
as the name of the original tool or at least the package name metawrap-mg
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really nice.
<command detect_errors="exit_code"><![CDATA[ | ||
## set memory usage | ||
if [ -n "\${GALAXY_MEMORY_MB}" ] ; then | ||
export GALAXY_MEMORY_GB="\$((GALAXY_MEMORY_MB / 1024))" ; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we should provide this centraly.. https://github.com/galaxyproject/galaxy/blob/ce7ef779c96d3fa0e3ef9e60a33433c266430e87/lib/galaxy/jobs/runners/util/job_script/MEMORY_STATEMENT_TEMPLATE.sh#L2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm happy to do that if you like, are the available env vars also documented somewhere central?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this would be nice. The env vars are documented here https://docs.galaxyproject.org/en/master/dev/schema.html#reserved-variables and in the linked planemo docs
Co-authored-by: Bérénice Batut <[email protected]>
Thanks @bebatut, I think there is a different tool somewhere called "metawrap". Happy to change it to |
Thanks @bernt-matthias |
Thanks @TomHarrop |
FOR CONTRIBUTOR:
Updating metawrap and moving it across from tools-au