Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add metawrap (from tools-au) #5936

Merged
merged 45 commits into from
Apr 11, 2024
Merged

Conversation

TomHarrop
Copy link
Contributor

@TomHarrop TomHarrop commented Apr 9, 2024

FOR CONTRIBUTOR:

  • I have read the CONTRIBUTING.md document and this tool is appropriate for the tools-iuc repo.
  • License permits unrestricted use (educational + commercial)
  • This PR adds a new tool or tool collection
  • This PR updates an existing tool or tool collection
  • This PR does something else (explain below)

Updating metawrap and moving it across from tools-au

@TomHarrop TomHarrop marked this pull request as draft April 9, 2024 00:23
@TomHarrop
Copy link
Contributor Author

This is running out of RAM

sh: line 1: 2312 Killed

@TomHarrop TomHarrop changed the title DRAFT/WIP Add metawrap Add metawrap (from tools-au) Apr 9, 2024
@TomHarrop TomHarrop marked this pull request as ready for review April 9, 2024 06:37
tools/metawrapmg/.shed.yml Outdated Show resolved Hide resolved
tools/metawrapmg/.shed.yml Show resolved Hide resolved
tools/metawrapmg/metawrapmg_binning.xml Outdated Show resolved Hide resolved
tools/metawrapmg/metawrapmg_binning.xml Outdated Show resolved Hide resolved
tools/metawrapmg/metawrapmg_binning.xml Show resolved Hide resolved
tools/metawrapmg/metawrapmg_binning.xml Outdated Show resolved Hide resolved
@TomHarrop
Copy link
Contributor Author

Thanks @bgruening

Copy link
Member

@bebatut bebatut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this tool

I have one question.

Would it be not better to have the folder as metawrap as the name of the original tool or at least the package name metawrap-mg?

tools/metawrapmg/.shed.yml Outdated Show resolved Hide resolved
Copy link
Contributor

@bernt-matthias bernt-matthias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really nice.

<command detect_errors="exit_code"><![CDATA[
## set memory usage
if [ -n "\${GALAXY_MEMORY_MB}" ] ; then
export GALAXY_MEMORY_GB="\$((GALAXY_MEMORY_MB / 1024))" ;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm happy to do that if you like, are the available env vars also documented somewhere central?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this would be nice. The env vars are documented here https://docs.galaxyproject.org/en/master/dev/schema.html#reserved-variables and in the linked planemo docs

tools/metawrapmg/metawrapmg_binning.xml Show resolved Hide resolved
tools/metawrapmg/metawrapmg_binning.xml Show resolved Hide resolved
tools/metawrapmg/metawrapmg_binning.xml Outdated Show resolved Hide resolved
Co-authored-by: Bérénice Batut <[email protected]>
@TomHarrop
Copy link
Contributor Author

Thanks for this tool

I have one question.

Would it be not better to have the folder as metawrap as the name of the original tool or at least the package name metawrap-mg?

Thanks @bebatut, I think there is a different tool somewhere called "metawrap". Happy to change it to metawrap-mg if the hyphen doesn't affect anything (e.g. toolshed url)?

@TomHarrop
Copy link
Contributor Author

Thanks @bernt-matthias

@bgruening bgruening merged commit 26fe7d2 into galaxyproject:main Apr 11, 2024
11 checks passed
@bgruening
Copy link
Member

Thanks @TomHarrop

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants