Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spades: also use version suffix #4712

Conversation

bernt-matthias
Copy link
Contributor

like all other *spades* tools

FOR CONTRIBUTOR:

  • - I have read the CONTRIBUTING.md document and this tool is appropriate for the tools-iuc repo.
  • - License permits unrestricted use (educational + commercial)
  • - This PR adds a new tool or tool collection
  • - This PR updates an existing tool or tool collection
  • - This PR does something else (explain below)

like all other `*spades*` tools
@bernt-matthias bernt-matthias marked this pull request as draft August 10, 2022 14:24
@bernt-matthias
Copy link
Contributor Author

@bgruening just realized that my previous PR #4711 was not necessary (For some reason on our system OMP_NUM_THREADS=1 is set on login .. I'm just investigating why).

It does not hurt, but may be confusing. I'm happy to revert. What do you think?

@bgruening
Copy link
Member

Its already deployed to the TS so there is no revert in the TS. You can merge that one here and kill the CI job to avoid another version in the TS ....?

@bernt-matthias bernt-matthias marked this pull request as ready for review April 14, 2023 13:08
@bernt-matthias bernt-matthias enabled auto-merge (squash) April 14, 2023 13:09
auto-merge was automatically disabled May 22, 2023 15:33

Pull request was closed

@bernt-matthias
Copy link
Contributor Author

#5949

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants