Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gi2taxonomy seems outdated #483

Open
bernt-matthias opened this issue Aug 28, 2017 · 3 comments
Open

gi2taxonomy seems outdated #483

bernt-matthias opened this issue Aug 28, 2017 · 3 comments

Comments

@bernt-matthias
Copy link
Contributor

The tool depends on package_taxonomy_1_0_0 which seems to be replaced by data_manager_fetch_ncbi_taxonomy.

Furthermore the data for the tool data is hard coded in the python file: see GI2TAX, NAME_FILE, NODE_FILE. It would be nice if

  • GI2tax could be taken from tool data of gi2taxonomy or the history and
  • the latter two somehow provided by the data_manager_fetch_ncbi_taxonomy.

This would be nice because the tool could then map arbitrary IDs (e.g. uniprot ids) to the taxonomy, given a mapping from the IDs to NCBI taxids.

One could also thing about to simplify the tool such that it creates the table only from the taxids and the mapping from the gi (or other ids) could be done with other tools (e.g. join).

@bgruening
Copy link
Member

The package_* should be replaced by a Conda package. It is compiling some C program. The data_manager is there to retrieve data sued by the compiled tool. That said the mentioned improvements are much needed!

@bernt-matthias
Copy link
Contributor Author

bernt-matthias commented Aug 29, 2017

OK. I would prefer to extend the ete package instead (https://toolshed.g2.bx.psu.edu/view/earlhaminst/ete/a4ba317fc713). The API has the same funtionality -- and can even search for names and taxids. I will try to do this these days.
I just have two questions:

  • how to use the data from data_manager_fetch_ncbi_taxonomy in the tool. maybe you can name me a tool that uses it already.
  • how to create the ete3 sqlite db from the ncbi taxonomy dump .. maybe it would be an idea to extend the data manager?

@bernt-matthias
Copy link
Contributor Author

I just started: see here: TGAC/earlham-galaxytools#90

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants