Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kubernetes Coexecution jobs are only removed under some circumstances #286

Open
natefoo opened this issue Oct 8, 2021 · 0 comments
Open

Comments

@natefoo
Copy link
Member

natefoo commented Oct 8, 2021

Such as:

  • When the user stops/deletes the job output(s)
  • When the job ends in error (because the Pulsar runner's fail_job() calls stop_job()

Circumstances where the job is not removed:

  • When the job finishes normally
  • When the job hits its (k8s) walltime and is killed by k8s

This last one is a source of job "loss" (stuck non-terminal) because Pulsar will never send a terminal status update. The runner should probably poll (as in galaxyproject/galaxy#9911) for this case.

The quickest and easiest (and IMO correct) solution would be to set the TTL in the template as described in the docs. But it would also be a good idea to call MessageCoexecutionPodJobClient.kill() for all jobs when their terminal message is received.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant