Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New toolshed categories are not updating for the existing tools #1480

Closed
pavanvidem opened this issue Oct 28, 2024 · 15 comments · Fixed by #1481
Closed

New toolshed categories are not updating for the existing tools #1480

pavanvidem opened this issue Oct 28, 2024 · 15 comments · Fixed by #1481

Comments

@pavanvidem
Copy link
Member

We recently added a few new toolshed categories to the existing tools in this PR: galaxyproject/tools-iuc#6114

The categories should have been updated in the toolsshed for at least the updated tools. But this is not the case. For eg., Scanpy has been updated recently but the new categories are not updated in the toolshed.

If a new tool is added, then the categories are updated. For example, the new Seurat tool suite belongs to the Single Cell category on toolshed.

@mvdbeek
Copy link
Member

mvdbeek commented Oct 28, 2024

That's not how it works, otherwise any user can create new (nonsense) categories. I'll create them.

@mvdbeek mvdbeek closed this as completed Oct 28, 2024
@mvdbeek
Copy link
Member

mvdbeek commented Oct 28, 2024

The categories exist, so I'm not sure what this is about.

@mvdbeek mvdbeek reopened this Oct 28, 2024
@bgruening
Copy link
Member

If Pavan adds a new category to the shed.yml (a category that exists in the TS already), its not populated upon push. I guess we need to understand why changes to a shed.yml is not reflected in the TS.

@mvdbeek
Copy link
Member

mvdbeek commented Oct 28, 2024

What repo is this ?

@pavanvidem
Copy link
Member Author

the tools are from IUC

@bgruening
Copy link
Member

@mvdbeek
Copy link
Member

mvdbeek commented Oct 28, 2024

Which tool repo is an example that should have been updated ?

@mvdbeek
Copy link
Member

mvdbeek commented Oct 28, 2024

Please be more specific. The PR just lists changes to the .shed.yml file

@pavanvidem
Copy link
Member Author

All the tools in that PR. For example Scanpy https://github.com/galaxyproject/tools-iuc/tree/main/tools/scanpy

@mvdbeek
Copy link
Member

mvdbeek commented Oct 28, 2024

I need a deploy commit, the last commit in there has not been deployed afaict

@mvdbeek
Copy link
Member

mvdbeek commented Oct 28, 2024

Or if you're not finding one let me know about a repo I can deploy.

@pavanvidem
Copy link
Member Author

I couldn't find. Please use Scanpy.

mvdbeek added a commit to mvdbeek/planemo that referenced this issue Oct 28, 2024
`category_ids[]` is not a valid agument for the update endpoint (it is
for create). To fix this I just call into bioblend instead of using the
custom put request. Fixes galaxyproject#1480
mvdbeek added a commit to mvdbeek/planemo that referenced this issue Oct 28, 2024
`category_ids[]` is not a valid agument for the update endpoint (it is
for create). To fix this I just call into bioblend instead of using the
custom put request. Fixes galaxyproject#1480
mvdbeek added a commit to mvdbeek/planemo that referenced this issue Oct 28, 2024
`category_ids[]` is not a valid agument for the update endpoint (it is
for create). To fix this I just call into bioblend instead of using the
custom put request. Fixes galaxyproject#1480
@mvdbeek
Copy link
Member

mvdbeek commented Oct 28, 2024

#1481 should fix this. I don't think it ever worked, so nice one!

@pavanvidem
Copy link
Member Author

pavanvidem commented Oct 28, 2024

@mvdbeek thanks a lot! I can see the Scanpy tools in the Single Cell category on toolshed.

This will trigger upon a tool update or? What about the other tools in that PR where I recently added the Single Cell category? Should I just bump the other tools' galaxy versions to trigger? is there a better trick?

@mvdbeek
Copy link
Member

mvdbeek commented Nov 15, 2024

Someone with iuc permissions can set the category in the TS user interface or reupload the package, which will also update the metadata.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants