-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve worklow names as shown in Galaxy #517
base: main
Are you sure you want to change the base?
Conversation
@mvdbeek directly into the PR or separate ones? |
Feel free to push to the PR or comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here are my suggestions.
@@ -554,7 +554,7 @@ | |||
}, | |||
"inputs": [], | |||
"label": "Compute fragment length histogram", | |||
"name": "Paired-end histogram", | |||
"name": "paired end histogram", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this change on purpose or a side effect?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's the tool name, shouldn't change it
@@ -11,7 +11,7 @@ | |||
"format-version": "0.1", | |||
"license": "MIT", | |||
"release": "0.11", | |||
"name": "ChIPseq_PE", | |||
"name": "ChIPseq: Paired End", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok
@@ -11,7 +11,7 @@ | |||
"format-version": "0.1", | |||
"license": "MIT", | |||
"release": "0.11", | |||
"name": "ChIPseq_SR", | |||
"name": "ChIPseq: Single Read", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK
@@ -82,7 +82,7 @@ | |||
"format-version": "0.1", | |||
"license": "MIT", | |||
"release": "1.1", | |||
"name": "Get Confident Peaks From ChIP_PE replicates", | |||
"name": "Get Confident Peaks From Paired End ChIP replicates", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK
@@ -82,7 +82,7 @@ | |||
"format-version": "0.1", | |||
"license": "MIT", | |||
"release": "1.1", | |||
"name": "Get Confident Peaks From ChIP_SR replicates", | |||
"name": "Get Confident Peaks From Single Read ChIP replicates", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK
workflows/epigenetics/hic-hicup-cooler/chic-fastq-to-cool-hicup-cooler.ga
Outdated
Show resolved
Hide resolved
workflows/epigenetics/hic-hicup-cooler/hic-fastq-to-cool-hicup-cooler.ga
Outdated
Show resolved
Hide resolved
workflows/epigenetics/hic-hicup-cooler/hic-juicermediumtabix-to-cool-cooler.ga
Outdated
Show resolved
Hide resolved
workflows/scRNAseq/fastq-to-matrix-10x/scrna-seq-fastq-to-matrix-10x-v3.ga
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just to avoid redundant work: you are aware of https://training.galaxyproject.org/training-material/workflows/list.html and checked if that's reuseable in some way?
workflows/amplicon/qiime2/qiime2-I-import/QIIME2-Ia-multiplexed-data-single-end.ga
Outdated
Show resolved
Hide resolved
@@ -1,6 +1,6 @@ | |||
{ | |||
"a_galaxy_workflow": "true", | |||
"annotation": "Importing demultiplexed data (single-end)", | |||
"annotation": "Importing demultiplexed data (single read)", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't it be single-end reads
instead of single read everywhere?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://www.illumina.com/science/technology/next-generation-sequencing/plan-experiments/paired-end-vs-single-read.html uses single read. I don't particularly care but we should choose one.
workflows/genome-assembly/bacterial-genome-assembly/bacterial_genome_assembly.ga
Outdated
Show resolved
Hide resolved
workflows/amplicon/qiime2/qiime2-I-import/QIIME2-Ia-multiplexed-data-single-end.ga
Outdated
Show resolved
Hide resolved
workflows/amplicon/qiime2/qiime2-I-import/QIIME2-Ia-multiplexed-data-single-end.ga
Outdated
Show resolved
Hide resolved
workflows/amplicon/qiime2/qiime2-I-import/QIIME2-Ib-multiplexed-data-paired-end.ga
Outdated
Show resolved
Hide resolved
workflows/amplicon/qiime2/qiime2-I-import/QIIME2-Ib-multiplexed-data-paired-end.ga
Outdated
Show resolved
Hide resolved
workflows/amplicon/qiime2/qiime2-I-import/QIIME2-Ib-multiplexed-data-paired-end.ga
Outdated
Show resolved
Hide resolved
workflows/amplicon/qiime2/qiime2-I-import/QIIME2-Ib-multiplexed-data-paired-end.ga
Outdated
Show resolved
Hide resolved
...flows/genome-assembly/quality-and-contamination-control/quality_and_contamination_control.ga
Outdated
Show resolved
Hide resolved
a4be211
to
f7328f0
Compare
The workflow name change will also benefit this, but I think we want a component that we can embed in the BRC analytics site where we need additional functionality. |
@Delphine-L could you also take a look at this ? |
@@ -21,7 +21,7 @@ | |||
"format-version": "0.1", | |||
"license": "CC-BY-4.0", | |||
"release": "0.2.2", | |||
"name": "Assembly-Hifi-HiC-phasing-VGP4", | |||
"name": "Contiging Solo with HiC data VGP4", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"name": "Contiging Solo with HiC data VGP4", | |
"name": "Assembly with Hifi reads and Hi-C data VGP4", |
@@ -16,7 +16,7 @@ | |||
"format-version": "0.1", | |||
"license": "CC-BY-4.0", | |||
"release": "0.2.1", | |||
"name": "Assembly-Hifi-only-VGP3", | |||
"name": "Contiging Solo VGP3", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"name": "Contiging Solo VGP3", | |
"name": "Assembly with Hifi reads VGP3", |
@Delphine-L you can add suggestions by using this https://stackoverflow.com/questions/54239733/how-can-i-manually-add-suggestions-in-code-reviews-on-github
I changed your suggestion accordingly.
@@ -15,7 +15,7 @@ | |||
], | |||
"format-version": "0.1", | |||
"license": "CC-BY-4.0", | |||
"name": "Mitogenome-Assembly-VGP0", | |||
"name": "Mitogenome Assembly VGP0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"name": "Mitogenome Assembly VGP0", | |
"name": "Mitogenome Assembly with Hifi data VGP0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is it maybe time to remove the VGPx suffix from all names?
@@ -16,7 +16,7 @@ | |||
"format-version": "0.1", | |||
"license": "CC-BY-4.0", | |||
"release": "0.4", | |||
"name": "Purge-duplicate-contigs-VGP6", | |||
"name": "Purge duplicate contigs VGP6", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"name": "Purge duplicate contigs VGP6", | |
"name": "Purge duplicate contigs from two haplotypes VGP6" |
@@ -16,7 +16,7 @@ | |||
"format-version": "0.1", | |||
"license": "CC-BY-4.0", | |||
"release": "0.7.1", | |||
"name": "Purging-duplicates-one-haplotype-VGP6b ", | |||
"name": "Purge Duplicate Contigs VGP6b", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"name": "Purge Duplicate Contigs VGP6b", | |
"name": "Purge duplicate contigs from one haplotypes VGP6b" |
@@ -16,7 +16,7 @@ | |||
"format-version": "0.1", | |||
"license": "CC-BY-4.0", | |||
"release": "0.2.7", | |||
"name": "Scaffolding-HiC-VGP8", | |||
"name": "Scaffolding with HiC data VGP8", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"name": "Scaffolding with HiC data VGP8", | |
"name": "Scaffolding with Hi-C data VGP8", |
@@ -15,7 +15,7 @@ | |||
"format-version": "0.1", | |||
"license": "CC-BY-4.0", | |||
"release": "0.1.4", | |||
"name": "kmer-profiling-hifi-trio-VGP2", | |||
"name": "K-mer profiling with HiFi trio data VGP2", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"name": "K-mer profiling with HiFi trio data VGP2", | |
"name": "K-mer profiling for PacBio HiFi and Trio data VGP2", |
@@ -11,7 +11,7 @@ | |||
"format-version": "0.1", | |||
"license": "MIT", | |||
"release": "0.3", | |||
"name": "cHi-C_fastqToCool_hicup_cooler", | |||
"name": "Hi-C: fastq to balanced cool using HiCUP and Cooler", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"name": "Hi-C: fastq to balanced cool using HiCUP and Cooler", | |
"name": "capture Hi-C: fastq to balanced cool using HiCUP and Cooler", |
@@ -11,7 +11,7 @@ | |||
"format-version": "0.1", | |||
"license": "MIT", | |||
"release": "0.5", | |||
"name": "baredSC_1d_logNorm", | |||
"name": "baredSC 1D logNorm", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK
@@ -11,7 +11,7 @@ | |||
"format-version": "0.1", | |||
"license": "MIT", | |||
"release": "0.5", | |||
"name": "baredSC_2d_logNorm", | |||
"name": "baredSC 2D logNorm", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK
@@ -31,7 +31,7 @@ | |||
"format-version": "0.1", | |||
"license": "MIT", | |||
"release": "0.4", | |||
"name": "scRNA-seq_preprocessing_10X_cellPlex", | |||
"name": "Single-cell RNA-seq fastq to matrix for 10X cellPlex data", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK
@@ -31,7 +31,7 @@ | |||
"format-version": "0.1", | |||
"license": "MIT", | |||
"release": "0.4", | |||
"name": "scRNA-seq_preprocessing_10X_v3_Bundle", | |||
"name": "Single-cell RNA-seq fastq to bundled matrix for 10X V3 data", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK
@@ -1,6 +1,6 @@ | |||
# Velocyto on 10X data | |||
|
|||
These workflows simply run velocyto. There are 2 workflows because one can be easily run after the 'fastq-to-matrix-10x' workflows (Velocyto-on10X-from-bundled). The other can be easily run from uploaded datasets (Velocyto-on10X-filtered-barcodes). | |||
These workflows simply run velocyto. There are 2 workflows because one can be easily run after the 'fastq-to-matrix-10x' workflows (Velocyto for 10X bundled data). The other can be easily run from uploaded datasets (Velocyto for 10X filtered barcode data). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These workflows simply run velocyto. There are 2 workflows because one can be easily run after the 'fastq-to-matrix-10x' workflows (Velocyto for 10X bundled data). The other can be easily run from uploaded datasets (Velocyto for 10X filtered barcode data). | |
These workflows simply run velocyto. There are 2 workflows because one can be easily run after the 'Single-cell RNA-seq fastq to bundled matrix for 10X ... data' workflows (Velocyto for 10X bundled data). The other can be easily run from uploaded datasets (Velocyto for 10X filtered barcode data). |
@@ -12,7 +12,7 @@ | |||
"format-version": "0.1", | |||
"license": "MIT", | |||
"release": "0.2", | |||
"name": "Velocyto-on10X-filtered-barcodes", | |||
"name": "Velocyto for 10X filtered barcode data", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK
@@ -12,7 +12,7 @@ | |||
"format-version": "0.1", | |||
"license": "MIT", | |||
"release": "0.2", | |||
"name": "Velocyto-on10X-from-bundled", | |||
"name": "Velocyto for 10X bundled data", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK
@@ -12,17 +12,17 @@ | |||
"format-version": "0.1", | |||
"license": "MIT", | |||
"release": "0.8", | |||
"name": "RNAseq_PE", | |||
"name": "RNA-seq Paired End", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK
@@ -11,7 +11,7 @@ | |||
], | |||
"format-version": "0.1", | |||
"license": "MIT", | |||
"name": "RNAseq_SR", | |||
"name": "RNA-seq Single Read", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK
@dannon is working on a static site listing our workflows, and we'd like to have better workflow names. I've made a first pass here, but I would love input from everyone.