Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the same Zig version for darwin #46

Open
Jacalz opened this issue Mar 29, 2024 · 2 comments
Open

Use the same Zig version for darwin #46

Jacalz opened this issue Mar 29, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@Jacalz
Copy link
Member

Jacalz commented Mar 29, 2024

The macOS images (darwin ) use a different version of Zig but does not motivate exactly whey. If this is fixed with newer versions, we should try to move to using the same one for all targets to avoid code complexity.

See

ENV ZIG_VERSION=0.9.1

Potentially related to #21.

@Jacalz Jacalz added the enhancement New feature or request label Mar 29, 2024
@andydotxyz
Copy link
Member

I understand the version of Zig to be very fragile and the specifics were picked for toolchains that worked in testing. That was a while ago though.

@Jacalz
Copy link
Member Author

Jacalz commented Apr 1, 2024

I understand the version of Zig to be very fragile and the specifics were picked for toolchains that worked in testing. That was a while ago though.

Indeed. I'm trying to make sure that all of the specific (and poorly documented) workarounds are documented somewhere. This doesn't necessarily mean that we need to remove them right now but we need to be aware of why they exist as well as how and when they can be removed.

Like you say, this was a while ago and without an issue to track it and with poor code documentation, it would unfortunately just have rotted away in the codebase.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants