Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: auto enable accounting period #692

Merged
merged 3 commits into from
Nov 18, 2024

Conversation

anishfyle
Copy link
Contributor

@anishfyle anishfyle commented Nov 18, 2024

Description

  • auto enable accounting period for new orgs

Clickup

Summary by CodeRabbit

  • New Features

    • Default behavior updated to export expenses when the accounting period is closed.
  • Bug Fixes

    • Adjusted the change_accounting_period setting to improve expense export functionality.
  • Chores

    • Updated PostgreSQL database dump metadata to reflect version changes.
    • Incremented version of the fyle-integrations-platform-connector package.

Copy link

coderabbitai bot commented Nov 18, 2024

Walkthrough

The changes involve modifying the change_accounting_period field in the WorkspaceGeneralSettings model located in apps/workspaces/models.py. The default value of this Boolean field has been updated from False to True, meaning the system will now export expenses by default when the accounting period is closed. A migration script has been created to reflect this change in the database schema. Additionally, updates were made to the PostgreSQL database dump metadata and the version of a package in the requirements.txt file.

Changes

File Path Change Summary
apps/workspaces/models.py Updated change_accounting_period field default from False to True in WorkspaceGeneralSettings model.
apps/workspaces/migrations/0047_alter_workspacegeneralsettings_change_accounting_period.py Migration script created to alter change_accounting_period field to BooleanField(default=True).
tests/sql_fixtures/reset_db_fixtures/reset_db.sql Updated PostgreSQL database dump metadata version from 15.8 to 15.9.
requirements.txt Updated fyle-integrations-platform-connector package version from 1.39.2 to 1.39.3.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant System
    User->>System: Close accounting period
    System->>System: Check change_accounting_period
    alt change_accounting_period is True
        System->>System: Export expenses
    else change_accounting_period is False
        System->>System: Do not export expenses
    end
Loading

🐇 "In the workspace where numbers play,
The period closed, expenses sway.
With a change so bold, we now declare,
Default exports, a new affair!
Hooray for settings, bright and true,
A hop, a skip, all thanks to you!" 🌼


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between 08bb5a4 and 11f882b.

📒 Files selected for processing (1)
  • requirements.txt (1 hunks)
✅ Files skipped from review due to trivial changes (1)
  • requirements.txt

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot added the size/XS Extra Small PR label Nov 18, 2024
Copy link

Tests Skipped Failures Errors Time
261 0 💤 0 ❌ 0 🔥 55.293s ⏱️

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between 7ae5979 and 3ddeaf1.

📒 Files selected for processing (1)
  • apps/workspaces/models.py (1 hunks)
🔇 Additional comments (1)
apps/workspaces/models.py (1)

107-107: Consider updating documentation to reflect the new default behavior.

Since this changes the default behavior for new organizations, it would be helpful to update relevant documentation to reflect that accounting periods are now enabled by default.

Let's check for documentation files that might need updates:

#!/bin/bash
# Description: Look for documentation files that might need updates
# Expected: Find documentation files mentioning accounting period settings

rg -l "accounting period" --type=md

apps/workspaces/models.py Show resolved Hide resolved
@github-actions github-actions bot added size/S Small PR and removed size/XS Extra Small PR labels Nov 18, 2024
Copy link

Tests Skipped Failures Errors Time
261 0 💤 0 ❌ 0 🔥 1m 2s ⏱️

@anishfyle anishfyle requested a review from ruuushhh November 18, 2024 05:12
Copy link

Tests Skipped Failures Errors Time
261 0 💤 0 ❌ 0 🔥 1m 0s ⏱️

@anishfyle anishfyle merged commit 8383a83 into handle-posted-at Nov 18, 2024
4 checks passed
anishfyle added a commit that referenced this pull request Nov 18, 2024
* model changes is posted at null

* update ver platform connector

* ver

* defaults

* updated fixtures

* update fixtures

* migrations

* updated fixtures

* reset db sql

* updated fixtures

* fixtures fixed

* updated fixtures

* fix tests, remove defaults

* feat: auto enable accounting period (#692)

* feat: auto enable accounting period

* migrations resetdb

* platform connector ver
@coderabbitai coderabbitai bot mentioned this pull request Nov 18, 2024
anishfyle added a commit that referenced this pull request Nov 18, 2024
* model changes is posted at null

* update ver platform connector

* ver

* defaults

* updated fixtures

* update fixtures

* migrations

* updated fixtures

* reset db sql

* updated fixtures

* fixtures fixed

* updated fixtures

* fix tests, remove defaults

* feat: auto enable accounting period (#692)

* feat: auto enable accounting period

* migrations resetdb

* platform connector ver
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/S Small PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants