-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: auto enable accounting period #692
Conversation
WalkthroughThe changes involve modifying the Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant System
User->>System: Close accounting period
System->>System: Check change_accounting_period
alt change_accounting_period is True
System->>System: Export expenses
else change_accounting_period is False
System->>System: Do not export expenses
end
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
✅ Files skipped from review due to trivial changes (1)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (1)
apps/workspaces/models.py
(1 hunks)
🔇 Additional comments (1)
apps/workspaces/models.py (1)
107-107
: Consider updating documentation to reflect the new default behavior.
Since this changes the default behavior for new organizations, it would be helpful to update relevant documentation to reflect that accounting periods are now enabled by default.
Let's check for documentation files that might need updates:
#!/bin/bash
# Description: Look for documentation files that might need updates
# Expected: Find documentation files mentioning accounting period settings
rg -l "accounting period" --type=md
|
|
* model changes is posted at null * update ver platform connector * ver * defaults * updated fixtures * update fixtures * migrations * updated fixtures * reset db sql * updated fixtures * fixtures fixed * updated fixtures * fix tests, remove defaults * feat: auto enable accounting period (#692) * feat: auto enable accounting period * migrations resetdb * platform connector ver
* model changes is posted at null * update ver platform connector * ver * defaults * updated fixtures * update fixtures * migrations * updated fixtures * reset db sql * updated fixtures * fixtures fixed * updated fixtures * fix tests, remove defaults * feat: auto enable accounting period (#692) * feat: auto enable accounting period * migrations resetdb * platform connector ver
Description
Clickup
Summary by CodeRabbit
New Features
Bug Fixes
change_accounting_period
setting to improve expense export functionality.Chores
fyle-integrations-platform-connector
package.