Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slow/Fast Action Option broken in System VAESEN #48

Open
3 tasks done
Tarubain opened this issue Oct 28, 2024 · 3 comments
Open
3 tasks done

Slow/Fast Action Option broken in System VAESEN #48

Tarubain opened this issue Oct 28, 2024 · 3 comments
Labels
bug Something isn't working

Comments

@Tarubain
Copy link

Describe the bug

I noticed that something weird is going on with the Slow/Fast Actions in combination with the System Vaesen. If I push the action buttons in the combat window, they sometimes work and sometimes they set the status for the combatant and immediately removes the status again. Sometimes it's throwing an error. In the Developer Console there are only deprecated messages.

I recorded this issue:

yze-combat-vaesen-bug.mp4

What I have tried so far:

  • Updated all components possible
  • Clean Install of the System
  • Clean Install of Addon
  • Created a blank new world with only the YZE Combat module active

Can someone reproduce this issue?

Reproduction

  1. Set an combatant
  2. Roll for initiative (get cards)
  3. Push Slow or Fast Action Button in the combat window

System Info

OS: macOS
Client: Foundry Desktop App
Foundry Build: 331 Version 12 Stable
System: Vaesen 6.0.3

Logs

Only deprecated yellow messages... no red errors

Priority this issue should have?

High (a broken feature, major functional impact)

Validations

  • Done a clean install of the system.
  • Disabled all modules.
  • Checked if the issue is present in a new world instance (create a new world in foundry using the module).
@Tarubain Tarubain added the bug Something isn't working label Oct 28, 2024
@DrOgres
Copy link
Member

DrOgres commented Oct 28, 2024

it might be conflicting with the conditions in the vaesen system, I noticed one actor has a condition and the second did not. if you turn off the conditions on both does it work as expected?

Either way i'll dig into the system implementation and see if I can track it down

@DrOgres DrOgres closed this as completed Oct 28, 2024
@DrOgres DrOgres reopened this Oct 28, 2024
@Tarubain
Copy link
Author

Hi David! I tested this with conditions active and inactive... with NSCs and without. (the left actor in the video is a NSC actor btw, but it doesn't matter at all though)

I noticed, that if you click on an action first, it works as expected, but if you do another click or with the next actor in the initiative row it begin to fail. Regardless slow or fast action...

@jacksands
Copy link

I've encountered the same problem with the Alien System. I am aware of some existing issues with this System, but I wish to report it nonetheless.

On a fresh install with no other modules, it worked once, which led me to believe it was a conflict. However, it stopped working after a few clicks.

It returned the following console error:

image

it is a much more complete solution than the native one, so I really enjoy this module! tks for your work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants