Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swipe up to toggle fullscreen stays in portrait mode #1571

Closed
3 tasks
McIrco95 opened this issue Dec 6, 2024 · 9 comments
Closed
3 tasks

Swipe up to toggle fullscreen stays in portrait mode #1571

McIrco95 opened this issue Dec 6, 2024 · 9 comments
Assignees
Labels
Bug Something isn't working Core Reproducible Solved Issue/feature has been fixed/implemented in development branch but not yet pushed to end users UI/UX

Comments

@McIrco95
Copy link

McIrco95 commented Dec 6, 2024

What happened?

The first time after restarting the app when i swipe up to toggle fullscreen mode before the video has started playing it opens fullscreen mode but with the video in portrait
Screenshot_20241207-004026

the fullscreen button works as expected but swipe up not.
When afterwards swiping down to toggle fullscreen and s swiping up again to toggle fullscreen i get normal fullscreen as expected

Same thing happens with the fullscreen button

Probably related to #779

Grayjay Version

268

What plugins are you seeing the problem on?

All

Plugin Version

No response

When do you experience the issue?

  • While logged in
  • While logged out
  • N/A

Relevant log output

No response

@Zvonimir-FUTO
Copy link
Collaborator

Seems to only happen when rotation is not "locked" in player. Happens for both Enabled and Same as System in settings.

@McIrco95
Copy link
Author

McIrco95 commented Dec 7, 2024

For me the rotation lock in the player does not make a difference
For me it also happens with auto rotate disabled in the settings.

With auto rotate setting enabled
and rotation lock in the player in the default position,
when swiping up to toggle fullscreen before the video starts playing,
the video opens in portrait
but when i rotate the phone it switches to landscape.
But as i said in #1572 normal behaviour now would be for rotation to be locked after swiping up to enable fullscreen

@kaidelorenzo kaidelorenzo self-assigned this Dec 7, 2024
@kaidelorenzo
Copy link
Member

Should addressed by this merge

https://gitlab.futo.org/videostreaming/grayjay/-/merge_requests/53

@Zvonimir-FUTO Zvonimir-FUTO added the Solved Issue/feature has been fixed/implemented in development branch but not yet pushed to end users label Dec 9, 2024
@SdoggaMan
Copy link

My comment here is applicable to this (and I think part of the same bug) #1572 (comment)

1 similar comment
@SdoggaMan
Copy link

My comment here is applicable to this (and I think part of the same bug) #1572 (comment)

@Zvonimir-FUTO
Copy link
Collaborator

This has been fixed in v276.

@McIrco95
Copy link
Author

Its more of a workaround than a fix. I just can't switch to fullscreen before the video starts playing. Making it feel unresponsive.
But with auto rotate on you can still rotate the phone. Leading to
Screenshot_20241214-123313

Also for some strange reason "always allow reverse landscape rotation" works fine in "grayjay unstable v276" but does not work in "grayjay v276". Both apps have sensor permissions so i dont know why.

@Zvonimir-FUTO Zvonimir-FUTO reopened this Dec 14, 2024
@Zvonimir-FUTO
Copy link
Collaborator

Yeah it's more of a workaround since Grayjay doesn't know the videos resolution before the video loads so it doesn't know if it should be full screen landscape or full screen portrait.

We will investigate that UI issues.

We will release another build next week which will hopefully fix it in stable as well.

@kaidelorenzo
Copy link
Member

These issues should have been address in the most recent update

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working Core Reproducible Solved Issue/feature has been fixed/implemented in development branch but not yet pushed to end users UI/UX
Projects
None yet
Development

No branches or pull requests

4 participants