From 337c7469d9c8c5fe050a508c5a581fa4f75ceb90 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?S=C3=A9bastien=20HOUZ=C3=89?= Date: Fri, 6 Sep 2019 15:44:05 +0200 Subject: [PATCH] feat: BREAKING CHANGE auto merge is now false by default on deployment creation --- README.md | 4 ++-- cmd/deployment.go | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/README.md b/README.md index 68d088f..e68fac4 100644 --- a/README.md +++ b/README.md @@ -64,7 +64,7 @@ jobs: env: GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} run: | - id=$(github deployment create --autoMerge=false --productionEnvironment=false --environment staging $GITHUB_REF) + id=$(github deployment create --productionEnvironment=false --environment staging $GITHUB_REF) github deployment_status create $id in_progress echo "##[set-output name=deployment_id;]$id" - env: @@ -111,7 +111,7 @@ jobs: env: GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} run: | - id=$(github deployment create --autoMerge=false $GITHUB_REF) + id=$(github deployment create $GITHUB_REF) echo "##[set-output name=deployment_id;]$id" # #-----------------------------8<---------------------------------------- # # here: some job(s) to add for example a deploy button/process diff --git a/cmd/deployment.go b/cmd/deployment.go index ad6294a..2b1735f 100644 --- a/cmd/deployment.go +++ b/cmd/deployment.go @@ -121,7 +121,7 @@ func init() { deployment.AddCommand(deploymentCreateCmd) deploymentCreateCmd.PersistentFlags().StringP("task", "t", "deploy", "Specifies a task to execute (e.g., deploy or deploy:migrations).") - deploymentCreateCmd.PersistentFlags().BoolP("autoMerge", "a", true, "Attempts to automatically merge the default branch into the requested ref, if it's behind the default branch.") + deploymentCreateCmd.PersistentFlags().BoolP("autoMerge", "a", false, "Attempts to automatically merge the default branch into the requested ref, if it's behind the default branch.") deploymentCreateCmd.PersistentFlags().StringSliceP("requiredContexts", "c", []string{}, "The status contexts to verify against commit status checks. If you omit this parameter, GitHub verifies all unique contexts before creating a deployment. To bypass checking entirely, pass an empty array. Defaults to all unique contexts.") deploymentCreateCmd.PersistentFlags().StringP("payload", "p", "", "JSON payload with extra information about the deployment.") deploymentCreateCmd.PersistentFlags().StringP("environment", "e", "production", "Name for the target deployment environment (e.g., production, staging, qa).")