Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Unit tests #24

Open
TitusKirch opened this issue Aug 2, 2022 · 4 comments · May be fixed by #677
Open

Create Unit tests #24

TitusKirch opened this issue Aug 2, 2022 · 4 comments · May be fixed by #677
Assignees
Labels
enhancement New feature or request priority/high
Milestone

Comments

@TitusKirch
Copy link
Contributor

N/A

@simonostendorf
Copy link
Contributor

First ideas for unit-tests (NOT COMPLETE, please add more tests if possible), see https://github.com/fsr5-fhaachen/portals/blob/dev_Alej_UTest/tests/test-scenarien.txt

@TobiasGrether
Copy link
Member

Update: Meeting with Ben for explanations today, testing code will be progressing further sooner this week

@TLE931
Copy link

TLE931 commented Aug 8, 2024

grobe Mitschrift von Bens Erklärungen zur Gruppeneinteilung:

Basisklasse GroupDivision

initiale Idee: assign() als einzige Methode, die vom Frontend aufgerufen wird

GroupCourseDivision: Aufteilung nach Studiengang
GroupBalancedDivision: Gleichmäßige Aufteilung

updateQueuePos: wird bei nicht zugeteilten Registrierungen gesetzt

calcOptFill: pro Studiengang Prozent Anteil aller Regisitrierungen ermitteln. Das ist dann für den Studiengang die optimale Füllrate pro Gruppe

nonDrinkers wird im Konstruktor festgelegt

bei balanced:
nicht-trinker Zuteilung wird bevorzugt

slots:
wenn queue position != null, ist User in Warteschlange, ansonsten bereits Slot zugewiesen

@jpih
Copy link
Contributor

jpih commented Aug 8, 2024

Group division test (until sunday July 11th 24)

Tom: GroupBalancedDivision
Jan: GroupCourseDivision, SlotAssignment

@simonostendorf simonostendorf added this to the Version 2.4.x milestone Aug 24, 2024
@simonostendorf simonostendorf linked a pull request Aug 29, 2024 that will close this issue
@simonostendorf simonostendorf modified the milestones: Version 3.0.x, 3.1.0 Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request priority/high
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants