Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor Move into subclasses #42

Open
barrybecker4 opened this issue Apr 12, 2020 · 0 comments
Open

Refactor Move into subclasses #42

barrybecker4 opened this issue Apr 12, 2020 · 0 comments

Comments

@barrybecker4
Copy link
Contributor

There is a comment in the Move class that reads:

This class is due for a refactoring, it does too much. It * should be divided into a MoveNode, a SetupNode and a RootNode which inherit * from an AbstractNode. This will also bring the object model in closer * correspondence with the structure of an SGF file.

There will also be a need to write a GameInfo class and provide a place

  • to attach it to the first distinguishing move in a tree of games beginning
  • with the move sequence. This will not be necessary until either loading of
  • ANY SGF file is supported, or the creation of multi-game trees is supported.
barrybecker4 added a commit to barrybecker4/LeelaWatcher that referenced this issue Apr 12, 2020
@barrybecker4
Refactor Move class. Initial cleanup (fsparv#42)
015ba3c 
Add some generics where needed.
Fix some warnings.
Fix typos in doc.
Remove some dead code.
barrybecker4 added a commit to barrybecker4/LeelaWatcher that referenced this issue Apr 12, 2020
@barrybecker4
Refactor Move class (fsparv#42)
8a56d5f 
Move Move into move subpackage in preparation for refactor.
barrybecker4 added a commit to barrybecker4/LeelaWatcher that referenced this issue Apr 12, 2020
@barrybecker4
Refactor Move class into subclasses (fsparv#42)
da23613 
Do the refactor into separate subclasses.
barrybecker4 added a commit to barrybecker4/LeelaWatcher that referenced this issue Apr 12, 2020
@barrybecker4
Refactor Move class into subclasses (fsparv#42)
c58a66c 
Do the refactor into separate subclasses.
@barrybecker4 barrybecker4 mentioned this issue Apr 12, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@barrybecker4