Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename filter_deleted to reject_deleted #1

Open
chadoh opened this issue Apr 5, 2018 · 1 comment
Open

Rename filter_deleted to reject_deleted #1

chadoh opened this issue Apr 5, 2018 · 1 comment

Comments

@chadoh
Copy link

chadoh commented Apr 5, 2018

Hello! Loving this plugin 😄

Since filter is a neutral word that could mean "filter for" or "filter out", what do you think of renaming this method to reject_deleted? A corresponding filter could be select_deleted.

@fsaravia
Copy link
Owner

@chadoh thanks! That's a great idea and thank you for helping me improve my English-fu.

I would like to keep a reference to filter_deleted for backwards compatibility reasons but I agree that renaming the original method will be helpful. I can work on this as soon as I have some bandwidth but PRs are always welcome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants