Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom Craft plugins (Asset and Entry/URL selection) not working with Froala v3 and v4 #23

Open
FreekVR opened this issue Dec 14, 2021 · 1 comment

Comments

@FreekVR
Copy link

FreekVR commented Dec 14, 2021

As far as I've been able to reproduce the Craft plugins for the editor itself ,including media asset selection and selecting entries using the link plugin, have never been updated to support Froala v3 and v4 respectively, while this repo has been receiving major version bumps for that package.

It appears to still be using the v2 jQuery-based API, and is throwing errors in the browser console due to that API no longer functioning with the Froala version included with this Craft plugin.

See #20 and #19 for basic functionality breaking due to this problem.

@FreekVR
Copy link
Author

FreekVR commented Dec 15, 2021

I've been able to fix some things in my fork:
https://github.com/DN-Amsterdam/Craft-3-Froala-WYSIWYG/blob/develop/src/assets/field/dist/js/plugins/craft.js

However there are still some issues I've been unable to resolve using available documentation

  • Image drag/drop is untested
  • Icons in the link dialog could be a bit bigger
  • Link popup select entry/asset buttons randomly fail on editor.popups.get('link.insert') being undefined
  • When link popup does work, it always inserts a new link at the beginning of the text, rather than at the current cursor or replacing the selected text
  • File insert is untested
  • Z-index issue with some Froala popups appearing behind other matrix blocks in Craft

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant