Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible race condition issue in streamProps #382

Open
fahad19 opened this issue Nov 28, 2017 · 0 comments
Open

Possible race condition issue in streamProps #382

fahad19 opened this issue Nov 28, 2017 · 0 comments

Comments

@fahad19
Copy link
Member

fahad19 commented Nov 28, 2017

Current situation

We ship streamProps helper function from frint-component-utils package, which allows combining values from various sources and then generate a single observable of props.

It uses concatMap operator from RxJS internally.

Possible bug

There is a possibility that with concatMap, we will have some race condition issue.

It is advised to use switchMap instead.

What to do

  • Write unit tests proving there is a race condition issue with streamProps
  • If there is, replace concatMap usage with switchMap without breaking the API
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant