Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMHtest throws an uncatchable "Error in solve.default(AVA)" #3

Open
bill-raynor opened this issue Jun 11, 2018 · 5 comments
Open

CMHtest throws an uncatchable "Error in solve.default(AVA)" #3

bill-raynor opened this issue Jun 11, 2018 · 5 comments

Comments

@bill-raynor
Copy link

For large sparse table (many strata) CMHTest will occasionally throw a Error in solve.default(AVA) Not surprising when I inspect the sub-tables as there are lots of zeros. However, I am unable to catch it with a tryCatch wrapped around the CMHtest call. Are there any downsides to replacing the solve call with a call to MASS::ginv as I would normally do for a linear model? (aside from speed issues)

@friendly
Copy link
Owner

As you say, your result for a large, sparse table with many strata is unsurprising. CMHtest was not designed for the situation of sparse tables, where solve doesn't work. We would not just substitute MASS::ginv without extensive testing.

If this issue is serious for you, you could clone the package, do some testing of an alternative, and file a patch or pull-request when you think you have a workable replacement.

@bill-raynor
Copy link
Author

What kind of testing would you suggest? Just a simple drop-in seems to work in the few cases I tested.. UNC-CH was where I learned about GENCAT, PARCAT, CATMOD and the rest of the GSK FARM stuff. Dick Landis was a year or two ahead of me. IIRC generalized inverses were being used that context, since GSK is a linear approximation. Its been 40+ years, though.

@friendly
Copy link
Owner

friendly commented Feb 9, 2019

This issue is still open, but I'd like to close it. As I said,

If this issue is serious for you, you could clone the package, do some testing of an alternative, and file a patch or pull-request when you think you have a workable replacement.

@bill-raynor
Copy link
Author

bill-raynor commented Feb 10, 2019 via email

@friendly
Copy link
Owner

You can issue a pull request & I'll check it out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants