-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow pymdownx-superfence-filter-lines-python to work with python 3.7-3.11 #24
Comments
Updated the issue description to propose a solution (with some minimum steps that need to be done). |
@llucax Most of the changes were pretty trivial. But since this repo depends on the repo-config, which requires python 3.11, we could either just remove the requirement or make repo-config support older python versions. What would you recommend I look into? |
Do the CI actions still work when repo-config would be removed as requirement? I think they hook a lot into it. (luca is a away this week) |
@jh2007github mmm, interesting. Removing repo-config will break releasing and other stuff, so it is not really an option. I would say just try to make repo-config compatible with 3.7, but if it is too much work, I will delay this, as is it not a priority. |
@llucax I briefly looked at what needs to be done. I think it should be manageable. So I guess the question is, whether I should do it now or if there is something more important to do. |
If you think it won't take much time (just one or two hours), please go ahead! |
What's needed?
Hey @llucax . As mentioned here, pymdownx-superfence-filter-lines-python currently is restricted to running on 3.11+.
Can pymdownx-superfence-filter-lines-python be allowed to run on python version 3.7+. Currently, the pip package in https://pypi.org/project/pymdownx-superfence-filter-lines/ restricts the user to using python 3.11+
Thanks!
Proposed solution
Lower the minimum required python version in
pyproject.toml
and expand the matrix in.github/workflows/ci.yaml
to test with python 3.7, 3.8, 3.9 and 3.10 too.Fix any issues that appear with the lower python versions.
The text was updated successfully, but these errors were encountered: