Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow pymdownx-superfence-filter-lines-python to work with python 3.7-3.11 #24

Open
geoffreyweal opened this issue Apr 16, 2024 · 6 comments
Labels
type:enhancement New feature or enhancement visitble to users
Milestone

Comments

@geoffreyweal
Copy link

geoffreyweal commented Apr 16, 2024

What's needed?

Hey @llucax . As mentioned here, pymdownx-superfence-filter-lines-python currently is restricted to running on 3.11+.

Can pymdownx-superfence-filter-lines-python be allowed to run on python version 3.7+. Currently, the pip package in https://pypi.org/project/pymdownx-superfence-filter-lines/ restricts the user to using python 3.11+

Thanks!

Proposed solution

Lower the minimum required python version in pyproject.toml and expand the matrix in .github/workflows/ci.yaml to test with python 3.7, 3.8, 3.9 and 3.10 too.

Fix any issues that appear with the lower python versions.

@geoffreyweal geoffreyweal added part:❓ We need to figure out which part is affected priority:❓ We need to figure out how soon this should be addressed type:enhancement New feature or enhancement visitble to users labels Apr 16, 2024
@llucax llucax removed part:❓ We need to figure out which part is affected priority:❓ We need to figure out how soon this should be addressed labels Apr 16, 2024
@llucax llucax added this to the v0.2.0 milestone Apr 16, 2024
@llucax
Copy link
Contributor

llucax commented Apr 16, 2024

Updated the issue description to propose a solution (with some minimum steps that need to be done).

@jack-herrmann
Copy link

@llucax Most of the changes were pretty trivial. But since this repo depends on the repo-config, which requires python 3.11, we could either just remove the requirement or make repo-config support older python versions. What would you recommend I look into?

@Marenz
Copy link
Contributor

Marenz commented Apr 22, 2024

Do the CI actions still work when repo-config would be removed as requirement? I think they hook a lot into it.
But maybe it won't be too hard to make it downwards compatible. You could do a superficial look and see how much work it might be.

(luca is a away this week)

@llucax
Copy link
Contributor

llucax commented Apr 29, 2024

@jh2007github mmm, interesting. Removing repo-config will break releasing and other stuff, so it is not really an option. I would say just try to make repo-config compatible with 3.7, but if it is too much work, I will delay this, as is it not a priority.

@jack-herrmann
Copy link

@llucax I briefly looked at what needs to be done. I think it should be manageable. So I guess the question is, whether I should do it now or if there is something more important to do.

@llucax
Copy link
Contributor

llucax commented Apr 30, 2024

If you think it won't take much time (just one or two hours), please go ahead!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:enhancement New feature or enhancement visitble to users
Projects
None yet
Development

No branches or pull requests

4 participants