Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements of energy metric calculation #14

Open
flora-hofmann-frequenz opened this issue Oct 2, 2024 · 0 comments
Open

Improvements of energy metric calculation #14

flora-hofmann-frequenz opened this issue Oct 2, 2024 · 0 comments

Comments

@flora-hofmann-frequenz
Copy link
Contributor

I realized some unrelated things though:

  • We rely on the data being sorted in the sum. This is currently usually the case but it's not guaranteed by the service.
  • If we have missing data this can be really off, depending on the cause of the missing data. We currently effectively treat NaNs as zeroes and forward-fill gaps in case we use raw data. This is inconsistent and I think we should just forbid resolution of Nones (although this wouldn't really fill gaps in the current version of the service, but in future only).
  • I think the start time of the CumulativeEnergy should be the timestamp of the first sample. The end time I think is fine if we always assume resampled data, otherwise we would need to adjust it too.

Originally posted by @cwasicki in #12 (review)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant