Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export all symbols from the main package #74

Open
llucax opened this issue Aug 20, 2024 · 0 comments
Open

Export all symbols from the main package #74

llucax opened this issue Aug 20, 2024 · 0 comments
Assignees
Labels
part:❓ We need to figure out which part is affected type:enhancement New feature or enhancement visitble to users
Milestone

Comments

@llucax
Copy link
Contributor

llucax commented Aug 20, 2024

What's needed?

This repository started as a container for multiple unrelated utilities, but now it is coming together as part of the BaseApiClient. Imports start to get a bit messy as one needs to pick some stuff from here and there, but all clients will need to import from all those subpackages, so it doesn't make sense to keep them separated.

Proposed solution

Make all subpackages private and export all symbols directly in frequenz.client.base.

@llucax llucax added part:❓ We need to figure out which part is affected type:enhancement New feature or enhancement visitble to users labels Aug 20, 2024
@llucax llucax added this to the v0.6.0 milestone Aug 20, 2024
@llucax llucax self-assigned this Aug 20, 2024
@llucax llucax modified the milestones: v0.6.0, v0.7.0 Aug 21, 2024
@llucax llucax modified the milestones: v0.7.0, v0.8.0 Oct 29, 2024
@llucax llucax modified the milestones: v0.8.0, v0.9.0 Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
part:❓ We need to figure out which part is affected type:enhancement New feature or enhancement visitble to users
Projects
None yet
Development

No branches or pull requests

1 participant