-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Address fuse limits redundancy in GridConnectionPoint
and Fuse
#246
Comments
GridConnectionPoint
GridConnectionPoint
and Fuse
I would say this is related to #242. It is also having metadata vs a component-graph based representation of some aspect of the microgrid. I think we should be ideally consistent and if we go with metadata, then allow it for I think the UI could help here, if we can add some rules based on the component, we might add a way to automatically always showing both a |
I think it is slightly different in concept to #242. #242 is specifically about representing a separate branch in the circuit. It is not about a property of a meter. This one is about our model for PCC (which we call In short, #242 is about representing electrical connections, whereas this issue is about the properties of Note that we cannot represent every property via different components (e.g., max feed-in power). So the current approach is still a valid one.
That is independent of the API definition. |
Yes, of course, this is why I said related :)
Yeah makes sense, of course if there are properties that are part of the grid connection point they should live as metadata/info of that component. If I understand correctly, this is sort of a virtual component, there is no grid connection point as a device, is just sort of 2 cabled being plug together, but there are regulations or contracts or requirements that put some restriction on how electricity can flow through that coupling right? For those, I think grid connection point metadata makes sense. If there is real physical device, like a fuse, just before the coupling, then from a "representing reality" perspective, it sounds like it makes more sense to have a fuse component in the component graph before the grid connection point, as we already have a fuse component.
Yeah, but making it harder for users to make mistakes while configuring the microgrid was brought up as a reason for going with metadata instead of a separate component, so I just brought it up because usability issues might be addressed somewhere else. |
We discussed this in a meeting. The conclusion was to keep the fuse limit field inside the In addition to that, we also concluded that the This issue can be closed. |
What's needed?
The
GridConnectionPoint
message has a fieldrated_fuse_current
to store the fuse limit at the grid connection point.frequenz-api-common/proto/frequenz/api/common/v1/microgrid/components/grid.proto
Lines 34 to 46 in c75dba3
However, we also have a dedicated message for fuses, called
Fuse
.frequenz-api-common/proto/frequenz/api/common/v1/microgrid/components/grid.proto
Lines 34 to 46 in c75dba3
This means that there are two different ways of specifying the fuse limit at the grid connection point -
GridConnectionPoint
entity, orFuse
entity as an immediate and only successor to aGridConnectionPoint
entityProposed solution
Proposal 1
We keep things as they are. That way we statically ensure that a grid connection point always has specified fuse limit.
If a
Fuse
entity is the only successor to aGridConnectionPoint
entity, then the effective fuse limit is the minimum of the two.Proposal 2
We remove
rated_fuse_current
fromGridConnectionPoint
, and always add a followingFuse
entity. This then needs to be checked by clients at runtime.Use cases
No response
Alternatives and workarounds
No response
Additional context
No response
The text was updated successfully, but these errors were encountered: