New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a bottom margin to ControlLabel #161

Open

huyenltnguyen opened this issue May 30, 2024 · 0 comments

Assignees

Labels

type: bug

Member

huyenltnguyen commented May 30, 2024

Description

I found that ControlLabel (renders a label) doesn't have a bottom margin, and it sits right above the input when combined with FormControl:

<FormGroup>
  <ControlLabel>Name</ControlLabel>
  <FormControl type="text" />
</FormGroup>

We are currently getting a bottom margin in /learn thanks to Bootstrap: https://github.com/twbs/bootstrap/blob/f17f882df292b29323f1e1da515bd16f326cee4a/dist/css/bootstrap.css#L2609.

I think either ControlLabel should have a bottom margin of 5px, or the FormGroup component should add a space of 5px between its children.

The text was updated successfully, but these errors were encountered:

huyenltnguyen added the type: bug label

huyenltnguyen self-assigned this

huyenltnguyen changed the title ~~Add a bottom margin to the label element of ControlLabel~~ Add a bottom margin to ControlLabel

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment