Skip to content

Commit

Permalink
STEPPED parameters mis-handled (#148)
Browse files Browse the repository at this point in the history
AudioParameterInt and CHoice use 0...1 normalizationfor their
lists. This makes them error prone under range changes, which is
an overall JUCE problem, but also means if we indicate them
as STEPPED in clap you can only select the extream in the bitwig
params view and so on. So for now stay with JUCE and make
these discrete types not stepped.
  • Loading branch information
baconpaul authored Apr 22, 2024
1 parent 0a3e7a6 commit e286d28
Showing 1 changed file with 6 additions and 1 deletion.
7 changes: 6 additions & 1 deletion src/wrapper/clap-juce-wrapper.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -1262,8 +1262,13 @@ class ClapJuceWrapper : public clap::helpers::Plugin<
if (paramVariant.processorParam->isAutomatable())
info->flags = info->flags | CLAP_PARAM_IS_AUTOMATABLE;

if (paramVariant.processorParam->isBoolean() || paramVariant.processorParam->isDiscrete())
if (paramVariant.processorParam->isBoolean())
{
// This condition used to say || paramVariant.processorParam->isDiscrete())
// but AudioProcessorChoice and Int normalize to 0...1 in
// JUCE so this ends up breaking the built in controls
// at the edge in CLAP vs VST3

info->flags = info->flags | CLAP_PARAM_IS_STEPPED;
}

Expand Down

0 comments on commit e286d28

Please sign in to comment.