Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace wkhtmltopdf with chrome #329

Open
maharshivpatel opened this issue Jul 19, 2024 · 3 comments
Open

replace wkhtmltopdf with chrome #329

maharshivpatel opened this issue Jul 19, 2024 · 3 comments
Labels
feature request New feature or request Priority: High

Comments

@maharshivpatel
Copy link
Collaborator

for a while, I have been doing a lot of workarounds, limiting features of print designer etc because wkhtmltopdf doesn't support modern CSS.

Also, a lot of stuff breaks and there is no way to debug such as content broken between pages. e.g. div inside span is possible in Chrome ( modern ) browser but will automatically escape out of span in wkhtmltopdf.

There are a lot of such cases and I have realised that if I combine time spent on such workarounds plus more that I have to spend in the future is less than what I will spend replacing wkhtmltopdf.

This was on my list for almost a year so finally I will be working on it.

@win8linux
Copy link

As mentioned originally in frappe/frappe#27595:

wkhtmltopdf has stopped development and its Git repo has been archived since 2023. Packages for it are beginning to fall behind that of Linux distributions, even with those that are not on a rolling release schedule. Additionally, having an unmaintained dependency that relies on a defunct QtWebKit web engine fork creates a large and porous attack surface.

@rmcdonald01
Copy link

rmcdonald01 commented Sep 22, 2024

How will we be notified when the change to Chrome has been made?

@1ubuntuuser
Copy link

How is this one going? Seems to be a major refactor. Is this happening offline?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request Priority: High
Projects
None yet
Development

No branches or pull requests

4 participants