Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scrollable x-axis on child table #14390

Closed
rtdany10 opened this issue Oct 7, 2021 · 16 comments · Fixed by #28536
Closed

Scrollable x-axis on child table #14390

rtdany10 opened this issue Oct 7, 2021 · 16 comments · Fixed by #28536

Comments

@rtdany10
Copy link
Contributor

rtdany10 commented Oct 7, 2021

Is your feature request related to a problem? Please describe.
Currently, child table grid view can only accommodate 11 columns. And we can't allocate float values to column width(bootstrap issues); thereby limiting number of columns in grid view to 5 columns or 6 at maximum.
Clicking Edit button to input values defeats the purpose of using Tab key.
Tab key is one of the things people love about Tally, you can literally do everything with the keyboard itself.

Describe the solution you'd like
If we add scroll-able x-axis on the child table, we can use Tab key to easily switch between fields and input all the required fields easily.

Additional context
TScroll

@ollyboy
Copy link
Contributor

ollyboy commented Oct 8, 2021

that would hide the edit button and mean you need to scroll to hit the edit button

@rtdany10
Copy link
Contributor Author

rtdany10 commented Oct 8, 2021

that would hide the edit button and mean you need to scroll to hit the edit button

Well, if you add all the commonly used fields, edit button would rarely be used.

But anyway, I think we can overcome this issue by keeping the serial number and edit button column fixed and rest all columns scrollable.

@asoral
Copy link

asoral commented Oct 8, 2021

This could be extremely useful in cases where user cant read descriptive columns in vhild table because of the length limitations, and has to edit individual lines. More so, if you have multiple lines then it gets a little taxing to check each individually

@marination
Copy link
Collaborator

@rtdany10 Sounds pretty cool! Is this feature already built ?

@rtdany10
Copy link
Contributor Author

rtdany10 commented Oct 28, 2021

@rtdany10 Sounds pretty cool! Is this feature already built ?

No, unfortunately, not yet. I will more than happily assist and help if somebody take the lead!
There are already pull requests that I've created that hasn't reached anywhere. Don't want to add another to the list.

@marination If you don't have much on your plate, could you try a hand?😅

@sumaiya2908 sumaiya2908 self-assigned this Jan 4, 2022
@sumaiya2908
Copy link
Contributor

@rtdany10 I am planning to implement this. Can I get a heads up?

@rtdany10
Copy link
Contributor Author

rtdany10 commented Jan 5, 2022

@rtdany10 I am planning to implement this. Can I get a heads up?

I'm unsure if I can provide you anything valuable. The GIF was created by altering the HTML of Sales Invoice form after it was rendered(via inspect element tool of my browser:sweat_smile:)
My understanding of Frappe's front-end is very basic but I'd like to learn. Will be more that happy to assist you. Let me know if you'd like to collaborate to get this done 😄

@rtdany10
Copy link
Contributor Author

rtdany10 commented Jul 6, 2022

@sumaiya2908 Any update on this?

@N-Codee
Copy link

N-Codee commented Oct 31, 2022

@rtdany10 how you did this ?.

@nasirrr
Copy link

nasirrr commented May 19, 2023

This is a very practical and necessary feature. After all, convenience and ease of use are what makes a s/w loved by all. Thanks for opening this request @rtdany10

Were you able to make any progress on this? @sumaiya2908

@systonium
Copy link
Contributor

This could be immensely helpful

@npatel2048
Copy link

that would hide the edit button and mean you need to scroll to hit the edit button

Well, if you add all the commonly used fields, edit button would rarely be used.

But anyway, I think we can overcome this issue by keeping the serial number and edit button column fixed and rest all columns scrollable.

Scrollable X axis in Child Table with having more than 10 Columns will be very helpful in multiple use Cases.
The Serial Number and Edit columns could be put in the Left and non scrollable.
Is there a Feature request for this in ERPNext Forum where we can UpVote it?

@mujeerhashmi
Copy link
Contributor

@shariquerik This is the issue, I discussed at the conference.

@npatel2048
Copy link

@mahesh042
Copy link

Any solution for this ?

@federicocalvo
Copy link

Finally! these things are incredibly necessary, there are reports that are hard to defend.
But for me, I think this PR is at the same level of usefulness if not more (of course it depends on one's point of view).

frappe/datatable#163

@sumitbhanushali sumitbhanushali removed their assignment Dec 3, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.