Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR with master? #3

Open
jtmkrueger opened this issue Jan 3, 2018 · 6 comments
Open

PR with master? #3

jtmkrueger opened this issue Jan 3, 2018 · 6 comments

Comments

@jtmkrueger
Copy link

Your awesome branch should be a part of master. You should put in a pr!

@franglais125
Copy link
Owner

Thanks for the kind words :)

In general, I try to push all the working code and bug fixes to master (https://github.com/paradoxxxzero/gnome-shell-system-monitor-applet). In this case, are you referring to some particular branch?

Regards

@CharoSW
Copy link

CharoSW commented Jan 10, 2018

I would guess the left position stuff as that's the stuff you've done that isn't merged. This is something which I would also like merged, if only so that I won't have to start editing the main extension again while also keeping up with various fixes that might go through to master

@jtmkrueger
Copy link
Author

Yea, sorry for the delay there. The left position stuff is what I was referring to.

@jtmkrueger
Copy link
Author

the add_position_options branch

@franglais125
Copy link
Owner

Thanks a lot for the (obvious, duh) pointer! I had completely forgotten about that branch.

Cheers!

@franglais125
Copy link
Owner

I forgot to mention that I rebased the branch as well, so if you want to grab it again it contains all the latest features/fixes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants