Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for activity-linked save & check enrichers, to match attack & damage versions #4862

Open
arbron opened this issue Dec 11, 2024 · 1 comment · May be fixed by #4961
Open

Add support for activity-linked save & check enrichers, to match attack & damage versions #4862

arbron opened this issue Dec 11, 2024 · 1 comment · May be fixed by #4961
Assignees
@arbron
Labels
blocked feature request system: enrichers
Milestone
D&D5E 4.2.0

Comments

@arbron
Copy link
Collaborator

arbron commented Dec 11, 2024 •
edited
Loading

The attack & damage enrichers can be linked to activities for fetching their information, it would be nice if that was also supported for check and save enrichers using the same format.

Blocked by #4898
@arbron
Copy link
Collaborator Author

arbron commented Dec 12, 2024

Will need to add support for multiple abilities in a single check & save enricher before this can be implemented.

@arbron arbron added the blocked label Dec 17, 2024
@arbron arbron mentioned this issue Dec 17, 2024
Closed
@arbron arbron self-assigned this Jan 3, 2025
@arbron arbron added this to the D&D5E 4.2.0 milestone Jan 3, 2025
arbron added a commit that referenced this issue Jan 3, 2025
@arbron
[#4862] Add activity-linked check & save enrichers
2e9ac65 
Allows for providing an activity ID to specify a specific activity
or leaving them blank to automatically find the first check or
save activity on the item.

```
[[/check]]
[[/check activity=RLQlsLo5InKHZadn]]
[[/save]]
[[/save activity=RLQlsLo5InKHZadn]]
```

Closes #4862
arbron added a commit that referenced this issue Jan 3, 2025
@arbron
[#4862] Add activity-linked check & save enrichers
9671b2c 
Allows for providing an activity ID to specify a specific activity
or leaving them blank to automatically find the first check or
save activity on the item.

```
[[/check]]
[[/check activity=RLQlsLo5InKHZadn]]
[[/save]]
[[/save activity=RLQlsLo5InKHZadn]]
```

Closes #4862
@arbron arbron linked a pull request Jan 3, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@arbron arbron

Labels
blocked feature request system: enrichers
Projects
None yet
Milestone
D&D5E 4.2.0
Development

Successfully merging a pull request may close this issue.

[#4862] Add activity-linked check & save enrichers foundryvtt/dnd5e
1 participant
@arbron