Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "Start of Combat" and "Start of Turn" activation types #4861

Closed
arbron opened this issue Dec 11, 2024 · 2 comments · Fixed by #4911
Closed

Add "Start of Combat" and "Start of Turn" activation types #4861

arbron opened this issue Dec 11, 2024 · 2 comments · Fixed by #4911

Comments

@arbron
Copy link
Collaborator

arbron commented Dec 11, 2024

When combat begins or when a turn begins, this would place a message in chat with a button to allow for easily triggering them. This would be useful for an ability like Regeneration which could automatically prompt DMs at the start of an NPCs turn and then they can decide whether to actually trigger the regeneration.

@JPMeehan
Copy link
Contributor

Can you also work in End of Turn?

@arbron
Copy link
Collaborator Author

arbron commented Dec 12, 2024

Yeah, I noticed at least one NPC that would require end of turn.

@arbron arbron added this to the D&D5E 4.2.0 milestone Dec 12, 2024
@arbron arbron self-assigned this Dec 20, 2024
arbron added a commit that referenced this issue Dec 20, 2024
Adds three new activation types in a new "Combat" section:
"Start of Encounter", "Start of Turn", and "End of Turn". These
activation types will display in the combat chat message with a
"Use" button to be easily activated. They also have a tooltip
to display the full item description on hover.

Closes #4861
arbron added a commit that referenced this issue Dec 20, 2024
Adds three new activation types in a new "Combat" section:
"Start of Encounter", "Start of Turn", and "End of Turn". These
activation types will display in the combat chat message with a
"Use" button to be easily activated. They also have a tooltip
to display the full item description on hover.

The turn chat message stores relative UUIDs of the activiations
in its data model to avoid having to check all of the actor's
items every time the chat message is rendered.

Closes #4861
arbron added a commit that referenced this issue Jan 3, 2025
Adds three new activation types in a new "Combat" section:
"Start of Encounter", "Start of Turn", and "End of Turn". These
activation types will display in the combat chat message with a
"Use" button to be easily activated. They also have a tooltip
to display the full item description on hover.

The turn chat message stores relative UUIDs of the activiations
in its data model to avoid having to check all of the actor's
items every time the chat message is rendered.

Closes #4861
arbron added a commit that referenced this issue Jan 4, 2025
Reworked where `_recoverUses` is called for start & end of turn
to ensure that the `turnStart` period is called for the first
combatant and to ensure these methods are always called for a GM
user.

Also fixes a bug where the dynamic ring is only being refreshed
for the user who presses the combat control buttons.

Changes the activity usage button in chat to be a rollable link
on the title, rather than a separate button.

Adjusts NPC sheets so that combat activations will appear in the
passive section.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants