Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restore tests that are disabled on Windows #2835

Open
cptartur opened this issue Jan 9, 2025 · 1 comment
Open

Restore tests that are disabled on Windows #2835

cptartur opened this issue Jan 9, 2025 · 1 comment
Labels
maintenance snforge

Comments

@cptartur
Copy link
Member

cptartur commented Jan 9, 2025

PR #2730 made some modules and tests disabled on Windows by introducing #[cfg(not(target_os = "windows"))] lines and similar.

Restore these tests on Windows.

Some of them will require changes or fixes to our existing codebase and related projects. Please create subissues for these.
@cptartur cptartur moved this to New in Starknet foundry Jan 9, 2025
@cptartur cptartur mentioned this issue Jan 9, 2025
Merged
5 tasks
@github-actions github-actions bot added the new label Jan 9, 2025
@emarc99
Copy link

emarc99 commented Jan 16, 2025

I can implement this and ensure tests passed.

@cptartur cptartur moved this from New to Triage in Starknet foundry Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
maintenance snforge
Projects
Starknet foundry
Status: Triage
Milestone
No milestone
Development

No branches or pull requests
2 participants
@cptartur @emarc99