Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pre-commit hooks for cargo-check, rustfmt, and clippy #12

Closed
declark1 opened this issue May 2, 2024 · 1 comment · Fixed by #83
Closed

Add pre-commit hooks for cargo-check, rustfmt, and clippy #12

declark1 opened this issue May 2, 2024 · 1 comment · Fixed by #83
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@declark1
Copy link
Collaborator

declark1 commented May 2, 2024

Description

Set up and configure pre-commit hooks for cargo-check (code errors), rustfmt (formatting), clippy (linting) to ensure clean code and reduce nit review comments.

@declark1 declark1 added enhancement New feature or request good first issue Good for newcomers labels May 2, 2024
@evaline-ju
Copy link
Collaborator

I realized I ended up adding some of this into the docker layers (since proto compilation was needed) on github actions with initial test runs - https://github.com/foundation-model-stack/fms-guardrails-orchestrator/blob/main/.github/workflows/test.yml. Only clippy and fmt were included

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants