Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pipfile: the replacement for requirements.txt #66

Open
Kaushl2208 opened this issue Mar 11, 2020 · 9 comments
Open

Pipfile: the replacement for requirements.txt #66

Kaushl2208 opened this issue Mar 11, 2020 · 9 comments
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers question Further information is requested

Comments

@Kaushl2208
Copy link
Member

We can migrate our current requirement.txt file to pipfile due to several reasons like:

  • TOML syntax for declaring all types of Python dependencies.
  • One Pipfile (as opposed to multiple requirements.txt files).
  • A Pipfile is inherently ordered.

or, Refer: Why?

@GMishx
Copy link
Member

GMishx commented Mar 12, 2020

That would be a good change. But will it effect the existing pyproject.toml (compatibility with PEP 518)?

@GMishx GMishx added enhancement New feature or request good first issue Good for newcomers question Further information is requested labels Mar 12, 2020
@Kaushl2208
Copy link
Member Author

Yes, It will replace pyproject.toml and it might affect setup.py. Not sure, about it rn.

Can I submit a PR for it?

@GMishx
Copy link
Member

GMishx commented Mar 13, 2020

Yes, sure @Kaushl2208. Just make sure the current build wheel build should not break because of this change.

@lohithmunakala
Copy link

Is this still open @GMishx ? I wanna work on this.

@GMishx
Copy link
Member

GMishx commented Sep 22, 2020

Yes @lohithmunakala, from my end the issue is still open. @Kaushl2208 do let us know if you are working on the issue.

It will be nice to assign the issue to the person currently working on it.

@lohithmunakala
Copy link

If @Kaushl2208 isn't working on it rn, can you help me get started with the issue @GMishx ?

@Kaushl2208
Copy link
Member Author

Hey @GMishx, We can assign this issue to @lohithmunakala. I don't have the rights to do so.

@hastagAB
Copy link
Member

Hey @GMishx, We can assign this issue to @lohithmunakala. I don't have the rights to do so.

Meanwhile @lohithmunakala You can start working on this issue. It will be a great help.

@GMishx
Copy link
Member

GMishx commented Sep 22, 2020

I have assigned the ticket to you @lohithmunakala .

You can start looking into pipenv documentation: https://pipenv.pypa.io/en/stable/
Expectation from this change is:

  1. Removal of dependencies from requirements.txt and setup.py
  2. Should not break PEP 517 changes (try to build Dockerfile to test)
  3. Clear separation of additional dependencies like csv and json files generated by running python3 setup.py build

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers question Further information is requested
Projects
None yet
Development

No branches or pull requests

4 participants