Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Hyperlinks in Responses have Ctrl+Click Shortcut for Opening in Browser #483

Closed
wants to merge 1 commit into from
Closed

fix: Hyperlinks in Responses have Ctrl+Click Shortcut for Opening in Browser #483

wants to merge 1 commit into from

Conversation

ARYPROGRAMMER
Copy link

@ARYPROGRAMMER ARYPROGRAMMER commented Oct 16, 2024 •
edited by ashitaprasad
Loading

PR Description

Resolves #265

Major Changes :

  • Added launchUrl function to incorporate browser opening event.
  • Added function to Parse the Raw text to identify Hyperlinks in ResponseBodyView as Raw.
  • Kept Core functionalities constant and differentiated the Hyperlink via SelectableText.rich method.
  • Provided tap gesture for mobile devices and ctrl+click for non-mobile.
  • Logically kept ResponseBodyView as Preview same as it already handles the case specified.

Related Issues

  • None

Checklist

  • I have gone through the contributing guide
  • I have updated my branch and synced it with project main branch before making this PR
  • I have run the tests (flutter test) and all tests are passing

Added/updated tests?

  • Yes
  • No, and this is why: No Core Functionalities or New Feature was added.

Reference Attachments :

  • Before Changes

Before Changes

  • After Changes

After Changes

  • Tests Run

Tests Run

@ashitaprasad
Copy link
Member

This PR adds link feature in the Raw tab which is not allowed.
Formatting/hyperlinks are only allowed in the Preview tab.
"Raw" tab shows the response in the pure raw text format.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Hyperlinks in responses (Preview mode) should have a ctrl+click shortcut for opening in browser
2 participants
@ARYPROGRAMMER @ashitaprasad