Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unclear instruction in activity #59

Open
stewartweiss opened this issue Jan 10, 2019 · 0 comments
Open

Unclear instruction in activity #59

stewartweiss opened this issue Jan 10, 2019 · 0 comments

Comments

@stewartweiss
Copy link

The description of step 8 in the activity makes it seem as if the maintainer is supposed to merge the PR at that step. The intention though, is that this is an overview stating what will eventually happen in a later step. The language in step 8:
"Follow the Contribution Workflow to accomplish this goal. Maintainer, when asked to review the PR, accept and merge the PR."
would be clearer if it read:
Follow the Contribution Workflow to accomplish this goal. The Maintainer, will eventually be asked to review the PR, accept and merge the PR in a future step.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant