Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suspicious funding #674

Open
Ivan1905 opened this issue Sep 10, 2024 · 4 comments
Open

Suspicious funding #674

Ivan1905 opened this issue Sep 10, 2024 · 4 comments
Assignees

Comments

@Ivan1905
Copy link
Collaborator

Hi Vasilis,

This address has been funded by TC with one hop: https://etherscan.io/address/0xd861e6f1760d014d6ee6428cf7f7d732563c74c0

Then executed an attack here: https://etherscan.io/tx/0x7e19f8edb1f1666322113f15d7674593950ac94bbc25d2aff96adabdcae0a6c3

For some reason the funding stage was not raised.

@Vxatz
Copy link
Contributor

Vxatz commented Sep 10, 2024

@salort-forta, the hops bot has an upper value threshold to prevent alert flooding. In one of the last changes we had adjusted the threshold e.g for Ethereum from 0.07ETH to 1.4ETH 3ecae56 (because of a previous FN). In this case, the value sent was 1.97ETH and that's why we missed it. Should I adjust it to 5ETH (and adjust the threshold on the other chains accordingly, based on the USD value)? (Could also adjust to 2-3ETH, but chances of running into the same issue again are getting higher).

(There's also the option of removing the threshold completely)

@salort-forta
Copy link
Contributor

Put it to 5. Do we have source-specific thresholds? [that is, would it be 5 only for TC or for everything?]

@Vxatz
Copy link
Contributor

Vxatz commented Sep 10, 2024

@salort-forta, will do.

We haven't, they are the same for all sources.

@Vxatz
Copy link
Contributor

Vxatz commented Sep 10, 2024

Thresholds updated in #675

(cc @Ivan1905)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants