Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move build to use tsdx as build tool #547

Merged
merged 1 commit into from
Aug 22, 2020
Merged

Move build to use tsdx as build tool #547

merged 1 commit into from
Aug 22, 2020

Conversation

felixmosh
Copy link
Contributor

@felixmosh felixmosh commented Aug 20, 2020

This PR moves the build system of the lib to use tsdx.

ps. TSDX utilises github actions as CI

Closes #546

  • Title is human readable, as it will be included directly in CHANGELOG.md when we do a release
  • If this is a new user-facing feature, documentation has been added to API.md
  • Any dist/ changes have not been committed.

Tests run directly on the source code and all dist changes are computed and committed during Formsy release.

@rkuykendall
Copy link
Member

This looks really slick. Do you think it's good to go @felixmosh ? Also am I understanding correctly that Travis failing is expected because the project would switch to Github Actions?

@rkuykendall
Copy link
Member

Okay wow, I finished reading everything and this looks great. Couldn't find anything to comment on. Some great catches in this PR. Merge when you feel comfortable and then set up the Github Actions?

@felixmosh
Copy link
Contributor Author

Cool, thanks for the review🙏

@felixmosh felixmosh merged commit 47a8030 into master Aug 22, 2020
@felixmosh
Copy link
Contributor Author

What will be the best way to release such change?

@rkuykendall rkuykendall deleted the move-to-tsdx branch August 22, 2020 17:43
@felixmosh felixmosh mentioned this pull request Aug 22, 2020
@rkuykendall
Copy link
Member

@felixmosh So the way I build and release is I go into master and I run npm run deploy. The only thing is you need to be added as a maintainer on NPM. Can you send me your NPM username? I'd love to have someone else who is also comfortable with releasing the project.

@felixmosh
Copy link
Contributor Author

felixmosh commented Aug 22, 2020

The question was semver wise :]
Is it a breaking change? WDYT?

@rkuykendall
Copy link
Member

I mean, technically nothing changes, right? But I guess something could be broken, so let's go with minor?

@felixmosh
Copy link
Contributor Author

felixmosh commented Aug 22, 2020

There are changes, "entry" files are different.

BTW, Github actions are enabled :]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Optimize bundle size
2 participants