From 246441e46ebbaff080910a7e893d0830a09d9cf5 Mon Sep 17 00:00:00 2001
From: Stephen Carter <stephen.carter@salesforce.com>
Date: Wed, 18 Dec 2024 16:28:43 -0500
Subject: [PATCH] Remove metadata based file extensions

---
 .../main/resources/sfca/rulesets/AppExchange_xml.xml   |  4 ----
 packages/code-analyzer-pmd-engine/src/constants.ts     | 10 +---------
 2 files changed, 1 insertion(+), 13 deletions(-)

diff --git a/packages/code-analyzer-pmd-engine/pmd-rules/src/main/resources/sfca/rulesets/AppExchange_xml.xml b/packages/code-analyzer-pmd-engine/pmd-rules/src/main/resources/sfca/rulesets/AppExchange_xml.xml
index 90497845..3bf7b20b 100644
--- a/packages/code-analyzer-pmd-engine/pmd-rules/src/main/resources/sfca/rulesets/AppExchange_xml.xml
+++ b/packages/code-analyzer-pmd-engine/pmd-rules/src/main/resources/sfca/rulesets/AppExchange_xml.xml
@@ -13,7 +13,6 @@
         <!-- TODO: NEED TO ADD IN externalInfoUrl ONCE WE HAVE A PERMANENT LOCATION FOR THE DOC PAGE -->
         <description>Detects use of Api.Session_ID or GETSESSIONID() to retrieve a session ID.</description>
         <priority>2</priority>
-        <!-- TODO: (NEED TO FINISHING GETTING LIST OF FILE EXTENSIONS FOR THIS RULE) This rule is associated with file extensions: ??, .object, .tab, .xml -->
         <properties>
             <property name="xpath">
                 <value><![CDATA[
@@ -35,7 +34,6 @@ contains(upper-case(@Text),"GETSESSIONID")
         <!-- TODO: NEED TO ADD IN externalInfoUrl ONCE WE HAVE A PERMANENT LOCATION FOR THE DOC PAGE -->
         <description>Detects use of API versions with Lightning Locker disabled in Aura components. Use API version 40 or greater.</description>
         <priority>1</priority>
-        <!-- This rule is associated with file extensions: .remoteSite, .xml -->
         <properties>
             <property name="xpath">
                 <value><![CDATA[
@@ -53,7 +51,6 @@ contains(upper-case(@Text),"GETSESSIONID")
         <!-- TODO: NEED TO ADD IN externalInfoUrl ONCE WE HAVE A PERMANENT LOCATION FOR THE DOC PAGE -->
         <description>Detects if &quot;Disable Protocol Security&quot; setting is true.</description>
         <priority>3</priority>
-        <!-- This rule is associated with file extensions: .remoteSite, .xml -->
         <properties>
             <property name="xpath">
                 <value><![CDATA[
@@ -71,7 +68,6 @@ contains(upper-case(@Text),"GETSESSIONID")
         <!-- TODO: NEED TO ADD IN externalInfoUrl ONCE WE HAVE A PERMANENT LOCATION FOR THE DOC PAGE -->
         <description>Detects instances of a Remote Site Settings that use HTTP. Use HTTPS instead.</description>
         <priority>3</priority>
-        <!-- This rule is associated with file extensions: .remoteSite, .xml -->
         <properties>
             <property name="xpath">
                 <value><![CDATA[
diff --git a/packages/code-analyzer-pmd-engine/src/constants.ts b/packages/code-analyzer-pmd-engine/src/constants.ts
index df17229e..7eacbd03 100644
--- a/packages/code-analyzer-pmd-engine/src/constants.ts
+++ b/packages/code-analyzer-pmd-engine/src/constants.ts
@@ -58,15 +58,7 @@ export const DEFAULT_FILE_EXTENSIONS: Record<Language, string[]> = {
 
     [Language.XML]: [
         // FROM PMD's XmlLanguageModule:
-        '.xml',
-
-        // Salesforce metadata file extensions to associate to XML language, specifically for the AppExchange rules:
-        //   Note: The metadata api pages over at
-        //           https://developer.salesforce.com/docs/atlas.en-us.api_meta.meta/api_meta/meta_types_list.htm
-        //         helps to list the file extensions for each metadata type. For example, the RemoteSiteSettings page
-        //           https://developer.salesforce.com/docs/atlas.en-us.api_meta.meta/api_meta/meta_remotesitesetting.htm
-        //         specifies that .remoteSite is the file extension for remote site settings files.
-        '.object', '.tab', '.remoteSite'
+        '.xml'
     ]
 }