From 9cf8e4f220ed029ffad7900330ef3688f360de24 Mon Sep 17 00:00:00 2001 From: Tobias Schneider Date: Thu, 4 Jul 2024 17:44:11 +0200 Subject: [PATCH 1/4] france: add missing subdivisions --- .../main/resources/holidays/Holidays_fr.xml | 391 +++++++++++++++++- 1 file changed, 378 insertions(+), 13 deletions(-) diff --git a/jollyday-core/src/main/resources/holidays/Holidays_fr.xml b/jollyday-core/src/main/resources/holidays/Holidays_fr.xml index 1c66e8739..99b423dd9 100644 --- a/jollyday-core/src/main/resources/holidays/Holidays_fr.xml +++ b/jollyday-core/src/main/resources/holidays/Holidays_fr.xml @@ -19,51 +19,416 @@ - + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + - - - - + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + - + + + + + + + + + + + + + + + + + + + + + + + + + + - + - + - + - + + + + + + + + + + + + + + + + + + + + - + - + - + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + From 5ff319377023c0f241d20011569293eb5b63dc7f Mon Sep 17 00:00:00 2001 From: Tobias Schneider Date: Wed, 4 Dec 2024 21:06:55 +0100 Subject: [PATCH 2/4] france: remove regions that have their own 3166 iso code closes #566 --- .../main/resources/holidays/Holidays_fr.xml | 58 ------------------- 1 file changed, 58 deletions(-) diff --git a/jollyday-core/src/main/resources/holidays/Holidays_fr.xml b/jollyday-core/src/main/resources/holidays/Holidays_fr.xml index 99b423dd9..2ab4c2b01 100644 --- a/jollyday-core/src/main/resources/holidays/Holidays_fr.xml +++ b/jollyday-core/src/main/resources/holidays/Holidays_fr.xml @@ -184,18 +184,6 @@ - - - - - - - - - - - - @@ -215,22 +203,6 @@ - - - - - - - - - - - - - - - - @@ -290,10 +262,6 @@ - - - - @@ -356,10 +324,6 @@ - - - - @@ -382,28 +346,6 @@ - - - - - - - - - - - - - - - - - - - - From 1c293d7dbbdd882ba52ca351a6e999a63b7c6a86 Mon Sep 17 00:00:00 2001 From: Tobias Schneider Date: Sat, 21 Dec 2024 16:52:05 +0100 Subject: [PATCH 3/4] =?UTF-8?q?france:=20fix=20duplicated=20hierarcy=20of?= =?UTF-8?q?=20M=C3=A9tropole=20de=20Lyon?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit closes #566 --- .../main/resources/holidays/Holidays_fr.xml | 62 +++++++++---------- 1 file changed, 29 insertions(+), 33 deletions(-) diff --git a/jollyday-core/src/main/resources/holidays/Holidays_fr.xml b/jollyday-core/src/main/resources/holidays/Holidays_fr.xml index 2ab4c2b01..4f7e7d02e 100644 --- a/jollyday-core/src/main/resources/holidays/Holidays_fr.xml +++ b/jollyday-core/src/main/resources/holidays/Holidays_fr.xml @@ -48,7 +48,7 @@ - + @@ -128,10 +128,6 @@ - - - - @@ -203,6 +199,34 @@ + + + + + + + + + + + + + + + + + + + + + + + + + + + + @@ -345,32 +369,4 @@ - - - - - - - - - - - - - - - - - - - - - - - - - - - - From 3bdd763785a8a774b24a8bc4773ec66df478f8f8 Mon Sep 17 00:00:00 2001 From: Tobias Schneider Date: Sat, 21 Dec 2024 17:02:36 +0100 Subject: [PATCH 4/4] france: remove First-level metropolitan subdivisions closes #566 --- .../main/resources/holidays/Holidays_fr.xml | 624 +++++++++--------- .../jollyday/tests/country/HolidayFRTest.java | 19 + 2 files changed, 319 insertions(+), 324 deletions(-) diff --git a/jollyday-core/src/main/resources/holidays/Holidays_fr.xml b/jollyday-core/src/main/resources/holidays/Holidays_fr.xml index 4f7e7d02e..2080996f0 100644 --- a/jollyday-core/src/main/resources/holidays/Holidays_fr.xml +++ b/jollyday-core/src/main/resources/holidays/Holidays_fr.xml @@ -19,354 +19,330 @@ - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + - - - - - - - - - - - - - - - - - - - - - - - - - - + + + + + + + + + + + + + + + + + + + + + + + + - - - - - - - - - - - - - - + + + + + + + + + + + + - - - - - - - - - - - - - - - - - - - - + + + + + + + + + + + + + + + + + + - + + + + + - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + - - - - - - - - - - - - - - - - - + + + + + + + + + + + + + + + - - - - - - - - - - - - - - - - - - - - - - - - - - + + + + + + + + + + + + + + + + + + + + + + + + - - - - - - - - - - - - - - - - - + + + + + + + + + + + + + + + - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + - - - - - - - - - - - - - - - - - + + + + + + + + + + + + + + + - - - - - - - - - - - - - - - - - - - - + + + + + + + + + + + + + + + + + + diff --git a/jollyday-tests/src/test/java/de/focus_shift/jollyday/tests/country/HolidayFRTest.java b/jollyday-tests/src/test/java/de/focus_shift/jollyday/tests/country/HolidayFRTest.java index ae367f5d9..50fb7456b 100644 --- a/jollyday-tests/src/test/java/de/focus_shift/jollyday/tests/country/HolidayFRTest.java +++ b/jollyday-tests/src/test/java/de/focus_shift/jollyday/tests/country/HolidayFRTest.java @@ -32,6 +32,25 @@ void ensuresHolidays() { .between(Year.of(1900), Year.of(2003)) .notBetween(Year.of(2004), Year.of(2007)) .between(Year.of(2008), Year.of(2500)) + .and() + + .hasFixedHoliday("ABOLITION_OF_SLAVERY", DECEMBER, 26) + .inSubdivision("57") + .and() + + .hasFixedHoliday("SECOND_CHRISTMAS_DAY", DECEMBER, 26) + .inSubdivision("67") + .and() + .hasChristianHoliday("GOOD_FRIDAY") + .inSubdivision("67") + .and() + + .hasFixedHoliday("SECOND_CHRISTMAS_DAY", DECEMBER, 26) + .inSubdivision("68") + .and() + .hasChristianHoliday("GOOD_FRIDAY") + .inSubdivision("68") + .check(); } }