Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fn init adds erroneous boilerplate to function dir w/ code existing #576

Open
rdallman opened this issue Apr 17, 2019 · 0 comments
Open

Comments

@rdallman
Copy link
Contributor

I have a Dockerfile and a go file in a directory, which is not named func.go (but is an fdk-friendly function). it looks like this:

✗: ls                   
build.sh  Dockerfile  fn-test-utils.go  Gopkg.lock  Gopkg.toml  release.sh

I run this:

✗: cli init --runtime go
Dockerfile found. Using runtime 'docker'.  
Function boilerplate generated.                  
func.yaml created.      
✗: git st                                       
## master...origin/master                         
 M ../../api/server/runner_fninvoke_test.go
?? func.go                                                                  
?? func.yaml                                
?? go.mod 

probably, since we detected runtime docker we shouldn't add boilerplate (for any lang, not just go)? seems odd anyway, I had to delete the file. basic assumption being if we find a dockerfile it's probably a valid function we just need to add it to fn? idk

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants